Vorago demo: Test-app support for wolfCrypt test/bench

[dgarske]

Fix for tools/scripts/va416x0/build_test.sh portability (MacOS)
Added option to support wolfCrypt test/benchmark in test-app
Add some checking if partition size is too large

[Copilot]

Pull request overview

This PR enhances the Vorago VA416x0 platform support by improving script portability for macOS, adding wolfCrypt test/benchmark capabilities to the test application, and implementing partition size validation.

Changes:

• Fixed JLinkExe detection for macOS compatibility in the build script
• Added wolfCrypt test and benchmark support to test-app with necessary infrastructure
• Implemented partition size checking to prevent oversized images

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
tools/test.mk	Updated ML_DSA size limit for test
tools/scripts/va416x0/build_test.sh	Added macOS JLinkExe detection and partition size validation
tools/keytools/sign.py	Added partition size overflow checking
tools/keytools/sign.c	Added partition size overflow checking
test-app/wolfcrypt_support.c	New file providing time and RNG functions for wolfCrypt
test-app/syscalls.c	New file providing newlib syscall stubs for embedded systems
test-app/app_va416x0.c	Added wolfCrypt test/benchmark integration
test-app/Makefile	Added build support for wolfCrypt test/benchmark
test-app/ARM-va416x0.ld	Increased heap and stack sizes
src/update_flash.c	Fixed MAX_UPDATE_SIZE calculation to include header size
include/user_settings.h	Added wolfCrypt test/benchmark configuration options
config/examples/vorago_va416x0.config	Updated partition layout and optimization settings
Makefile	Added WOLFBOOT_PARTITION_SIZE to sign tool environment

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated 8 comments.

Comments suppressed due to low confidence (1)

tools/keytools/sign.py:97

• Inside make_header(), assignments to WOLFBOOT_PARTITION_SIZE / WOLFBOOT_SECTOR_SIZE create locals unless declared global, so the later size check will still see the module-level values (currently 0) and never run. Declare these as global in the function (or refactor to pass them through) so the partition-size guard actually takes effect.

def make_header(image_file, fw_version, extra_fields=[]):

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[collin-peterson-apex]

Hello, do these fixes apply to all va416xx boards, or just the va416x0?

[Copilot]

Pull request overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated 6 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated 8 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated 3 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.