support new wolfHSM multi-root-CA verification#776
Open
bigbrett wants to merge 2 commits into
Open
Conversation
Contributor
bigbrett
commented
May 11, 2026
- Updates the wolfHSM certificate verification to use the new multi-root API and allow user to specify a list of root CA NVM IDs for verification. This enables signing images with different chains corresponding to different roots without requiring a firmware update to wolfBoot.
- Updates wolfHSM to latest
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates wolfBoot’s wolfHSM-based certificate chain verification to support the new multi-root API, allowing verification against a configurable list of trusted root CA NVM IDs, and bumps the wolfHSM submodule.
Changes:
- Switch certificate verification calls to wolfHSM “MultiRoot” APIs (DMA / non-DMA, client / server).
- Replace single root CA NVM ID HAL export with a root CA list + count.
- Update docs and bump the wolfHSM submodule revision.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/image.c | Uses wolfHSM MultiRoot verification APIs and passes root list + count. |
| include/hal.h | Updates HAL interface to expose root CA list + count instead of a single ID. |
| hal/sim.c | Provides default root CA list/count and a build-time override macro for simulator. |
| hal/aurix_tc3xx.c | Provides default root CA list/count and a build-time override macro for AURIX. |
| docs/wolfHSM.md | Documents multi-root provisioning and new HAL exports / build-time override. |
| lib/wolfHSM | Updates wolfHSM submodule pointer to a newer commit. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #776
Scan targets checked: wolfboot-bugs, wolfboot-src
No new issues found in the changed files. ✅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.