Add size check in wh_Client_Curve25519SharedSecret

Author: padelsbach

src/wh_client_crypto.c

@@ -2826,14 +2826,33 @@ int wh_Client_Curve25519SharedSecret(whClientContext* ctx,
                     /* wolfCrypt allows positive error codes on success in some
                      * scenarios */
                     if (ret >= 0) {
-                        if (out_size != NULL) {
+                        uint8_t*     res_out = (uint8_t*)(res + 1);
+                        const size_t hdr_sz =
+                            sizeof(whMessageCrypto_GenericResponseHeader) +
+                            sizeof(*res);
+                        /* Defensive bound: res->sz must fit within the actual
+                         * received frame */
+                        if (res_len < hdr_sz ||
+                            res->sz > (res_len - hdr_sz)) {
+                            ret = WH_ERROR_ABORTED;
+                        }
+                        else if ((out != NULL) && (out_size != NULL) &&
+                                 (res->sz > *out_size)) {
+                            /* Output buffer too small. Report required size and
+                             * fail rather than silently truncating X25519 key
+                             * material. */
                             *out_size = res->sz;
+                            ret      = WH_ERROR_BUFFER_SIZE;
                         }
-                        if (out != NULL) {
-                            uint8_t* res_out = (uint8_t*)(res + 1);
-                            memcpy(out, res_out, res->sz);
-                            WH_DEBUG_VERBOSE_HEXDUMP("[client] X25519:", res_out,
-                                             res->sz);
+                        else {
+                            if (out_size != NULL) {
+                                *out_size = res->sz;
+                            }
+                            if ((out != NULL) && (res->sz > 0)) {
+                                memcpy(out, res_out, res->sz);
+                                WH_DEBUG_VERBOSE_HEXDUMP("[client] X25519:",
+                                                         res_out, res->sz);
+                            }
                         }
                     }
                 }