Skip to content

add missing post-write DMA callbacks for AES GCM #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexLanzano merged 1 commit into from
Oct 17, 2025
Merged

add missing post-write DMA callbacks for AES GCM #215

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions src/wh_server_crypto.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2112,6 +2112,33 @@ static int _HandleAesGcmDma(whServerContext* ctx, uint16_t magic, uint16_t seq,
}
}

/* Post-write DMA address processing for output/authTag (on success) */
if (ret == WH_ERROR_OK) {
if (req.output.sz > 0) {
int rc2 = wh_Server_DmaProcessClientAddress(
ctx, req.output.addr, &outAddr, req.output.sz,
WH_DMA_OPER_CLIENT_WRITE_POST, (whServerDmaFlags){0});
if (rc2 != WH_ERROR_OK) {
if (rc2 == WH_ERROR_ACCESS) {
res.dmaAddrStatus.badAddr = req.output;
}
ret = rc2;
}
}
/* During encryption, the auth tag is written to client memory */
if (ret == WH_ERROR_OK && req.enc && req.authTag.sz > 0) {
int rc2 = wh_Server_DmaProcessClientAddress(
ctx, req.authTag.addr, &authTagAddr, req.authTag.sz,
WH_DMA_OPER_CLIENT_WRITE_POST, (whServerDmaFlags){0});
if (rc2 != WH_ERROR_OK) {
if (rc2 == WH_ERROR_ACCESS) {
res.dmaAddrStatus.badAddr = req.authTag;
}
ret = rc2;
}
}
}

wc_AesFree(aes);
res.outSz = outSz;

Expand Down