Skip to content

remove AES GCM output NULL check #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexLanzano merged 1 commit into from
Oct 20, 2025
Merged

remove AES GCM output NULL check #221

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/wh_client_crypto.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -692,7 +692,7 @@ int wh_Client_AesGcm(whClientContext* ctx, Aes* aes, int enc, const uint8_t* in,
if ((ctx == NULL) || (aes == NULL) || ((in == NULL) && (len > 0)) ||
((iv == NULL) && (iv_len > 0)) ||
((authin == NULL) && (authin_len > 0)) ||
((enc == 0) && (dec_tag == NULL)) || (out == NULL)) {
((enc == 0) && (dec_tag == NULL))) {
return WH_ERROR_BADARGS;
}

Expand Down Expand Up @@ -811,7 +811,7 @@ int wh_Client_AesGcm(whClientContext* ctx, Aes* aes, int enc, const uint8_t* in,
res->authTagSz);
}
#endif
/* copy the response result */
/* copy the response result if present */
if (out != NULL && res->sz == len) {
memcpy(out, res_out, res->sz);
}
Expand Down Expand Up @@ -859,7 +859,7 @@ int wh_Client_AesGcmDma(whClientContext* ctx, Aes* aes, int enc,
uint32_t keyLen = 0;
uint16_t reqLen;

if (ctx == NULL || aes == NULL || out == NULL) {
if (ctx == NULL || aes == NULL) {
return WH_ERROR_BADARGS;
}

Expand Down