zero-initialize SHA-224/384/512 response structs#308
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves safety/consistency of SHA2 server-side handlers by zero-initializing whMessageCrypto_Sha2Response before it’s translated and sent back to the client, reducing the risk of returning uninitialized stack data.
Changes:
- Zero-initialize
whMessageCrypto_Sha2Response resin_HandleSha224 - Zero-initialize
whMessageCrypto_Sha2Response resin_HandleSha384 - Zero-initialize
whMessageCrypto_Sha2Response resin_HandleSha512
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
bigbrett
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes a small but important change to the initialization of the
whMessageCrypto_Sha2Responsestructure in several SHA handler functions. The structure is now zero-initialized at declaration to prevent potential issues with uninitialized memory.whMessageCrypto_Sha2Responsevariable in the_HandleSha224,_HandleSha384, and_HandleSha512functions insrc/wh_server_crypto.cto ensure all fields are set to known values before use. [1] [2] [3]