Add size check in wh_Client_Curve25519SharedSecret#361
Merged
Conversation
padelsbach
force-pushed
the
curve25519-size-check
branch
from
9030316 to
721d935
Compare
bigbrett
requested changes
May 11, 2026
Contributor
bigbrett
left a comment
bigbrett
left a comment
There was a problem hiding this comment.
Hmm could we actually change this to mirror how we do it in ECDH and simply gating the memcpy on out_size != NULL? As written, when a caller passes an output buffer but no size pointer, the function still writes the server's data into that buffer without checking it fits. Would simplify the logic
bigbrett
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes F-3799