bound remain_len in publishresp, disconnect and auth decoders#553
Closed
jmestwa-coder wants to merge 1 commit into
Closed
bound remain_len in publishresp, disconnect and auth decoders#553jmestwa-coder wants to merge 1 commit into
jmestwa-coder wants to merge 1 commit into
Conversation
|
Can one of the admins verify this patch? |
Author
|
No problem, makes sense to roll these into #552. For reference the guards go right after MqttDecode_FixedHeader in MqttDecode_PublishResp, MqttDecode_Disconnect and MqttDecode_Auth, mirroring the same check MqttDecode_Connect and MqttDecode_Subscribe already carry. There are three failing regression tests in tests/test_mqtt_packet.c covering each one if they're useful to pull across. Happy for you to close this out. |
Member
|
Closing this PR as it was superseded by #552 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reason code byte read past rx_buf in three v5 ack decoders:
added the rx_buf_len < header_len + remain_len guard that MqttDecode_Connect and MqttDecode_Subscribe already carry, plus regression tests that fault pre-patch and return out-of-buffer after.