Store the current object ID in token#106
Merged
Merged
Conversation
LinuxJedi
force-pushed
the
token-storage-fixes
branch
5 times, most recently
from
16d8d9f to
2d9fad9
Compare
dgarske
requested changes
Jun 27, 2025
Member
dgarske
left a comment
dgarske
left a comment
There was a problem hiding this comment.
Reviewed and tested. Great otherwise
LinuxJedi
force-pushed
the
token-storage-fixes
branch
from
2d9fad9 to
42da9cc
Compare
dgarske
requested changes
Jun 27, 2025
LinuxJedi
force-pushed
the
token-storage-fixes
branch
6 times, most recently
from
fc46745 to
4eccc62
Compare
dgarske
requested changes
Jun 27, 2025
LinuxJedi
force-pushed
the
token-storage-fixes
branch
from
4eccc62 to
fc2f22f
Compare
dgarske
requested changes
Jun 27, 2025
When a token is stored and then reloaded during `C_Initialize`, the token object IDs are reset to zero. Which means new objects will end up with the same IDs as loaded objects. This is probably a "bad thing", so let's not do that. With this patch the next object ID is stored with the token. Also: * Fix MD5 breaking tests with wolfSSL#8895 change. * Fix parallel tests storage race condition
LinuxJedi
force-pushed
the
token-storage-fixes
branch
from
fc2f22f to
a9f8e8d
Compare
dgarske
approved these changes
Jun 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a token is stored and then reloaded during
C_Initialize, the token object IDs are reset to zero. Which means new objects will end up with the same IDs as loaded objects.This is probably a "bad thing", so let's not do that. With this patch the next object ID is stored with the token.
Also: