Skip to content

Add NSS curl 8.0.0 test#112

Merged
dgarske merged 5 commits into
wolfSSL:masterfrom
mattia-moffa:20250715-nss-curl-test
Jul 22, 2025
Merged

Add NSS curl 8.0.0 test#112
dgarske merged 5 commits into
wolfSSL:masterfrom
mattia-moffa:20250715-nss-curl-test

Conversation

@mattia-moffa

@mattia-moffa mattia-moffa commented Jul 15, 2025

Copy link
Copy Markdown
Member

Verifies that curl -v https://example.com/ runs successfully using curl-8.0.0+NSS+wolfPKCS11.

@mattia-moffa mattia-moffa self-assigned this Jul 15, 2025
@LinuxJedi

Copy link
Copy Markdown
Member

There is a reason I resisted doing this direct conversion from the Dockerfile, and it is the fact that we are relying on an external service to exist / work. This external service does use some form of flood protection. I managed to trigger it during testing and get my IP temporarily banned. Even if it didn't, it doesn't feel right to me to hit it like this.

Some thoughts on how to solve this:

  • Maybe using a GH URL is OK? Given that it is GitHub Actions calling it.
  • Maybe start up a basic HTTPS server to test against.

@mattia-moffa

mattia-moffa commented Jul 21, 2025

Copy link
Copy Markdown
Member Author

Agreed. Shall I just replace https://example.com/ with https://github.com/? I feel like setting up an HTTPS server with valid certs in the GitHub action is overkill in this situation, we're relying on APT repositories and on GitHub itself to install the software at the beginning anyway.

@LinuxJedi

Copy link
Copy Markdown
Member

I think that should work

@LinuxJedi LinuxJedi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Thanks for caching too.

Context for PR captain: Curl 8.0.0 is used because newer versions removed NSS support. But it makes for a good TLS test.

@dgarske dgarske merged commit afb67e6 into wolfSSL:master Jul 22, 2025
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants