Improve error handling for C_Login#115
Merged
Merged
Conversation
If a login fails for any reason, it would show `CKR_PIN_INCORRECT`, even if the cause was an object decode error after login succeeded. This commit: * Simplifies the error handling * Uses `CKR_DEVICE_MEMORY` for TPM memory errors * Uses `CKR_DEVICE_ERROR` for all other errors * Logs the original return code in the debug log
dgarske
approved these changes
Jul 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a login fails for any reason, it would show
CKR_PIN_INCORRECT, even if the cause was an object decode error after login succeeded.This commit:
CKR_DEVICE_MEMORYfor TPM memory errorsCKR_DEVICE_ERRORfor all other errors