Make ECC curve lookup internal#125
Merged
Merged
Conversation
douzzer
previously requested changes
Aug 6, 2025
Contributor
douzzer
left a comment
douzzer
left a comment
There was a problem hiding this comment.
can we gate the insourcing on defined(HAVE_FIPS) && FIPS_VERSION_LT(6,0)?
we want to maintain proper test coverage of the libwolfssl implementation in the provider tests when linked with v6+ or non-FIPS libwolfssl.
In FIPSv5, `wc_ecc_get_curve_id_from_oid` is broken. With certain build configurations the OIDs are the wrong type too. Also with FIPSv5 the `ecc_sets` list is not available. So, this PR brings the lookup in-house.
dgarske
approved these changes
Aug 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In FIPSv5,
wc_ecc_get_curve_id_from_oidis broken. With certain build configurations the OIDs are the wrong type too. Also with FIPSv5 theecc_setslist is not available. So, this PR brings the lookup in-house.