Skip to content

Commit 2b2573d

Browse files
committed
ci: drop wait_for_smoke gates; PR workflows fire in parallel with smoke
The wait_for_smoke job (composite action that polls Smoke Test on the PR head SHA) was forcing every other PR workflow to wait for smoke before kicking off. End result: smoke + multi-compiler + sanitizers were serialized when they could be parallel. What we wanted from this gate -- "don't burn CI on a broken build" -- isn't actually saving much. Smoke takes the same wall time as the shortest other workflow, and PR-mode draft-skip already prevents the sweep on WIP PRs. The gate was holding back the open-PR signal more than it was saving runner-minutes. Strip it everywhere: - simple, cmdline, fips-ready, openssl-version, seed-src, multi-compiler, sanitizers - the OSP workflows already had it removed in the nightly move. Draft-skip stays. Smoke itself still runs on PR -- it's just no longer a barrier in front of everything else. The .github/actions/wait-for-smoke composite action stays in the tree; nothing references it now, but it's small and harmless to keep around in case someone wants to opt a specific workflow back into it.
1 parent b249331 commit 2b2573d

7 files changed

Lines changed: 3 additions & 98 deletions

File tree

.github/workflows/cmdline.yml

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -25,21 +25,7 @@ concurrency:
2525
# END OF COMMON SECTION
2626

2727
jobs:
28-
wait_for_smoke:
29-
name: Wait for smoke
30-
if: github.event_name != 'pull_request' || github.event.pull_request.draft == false
31-
runs-on: ubuntu-22.04
32-
timeout-minutes: 35
33-
steps:
34-
- uses: actions/checkout@v4
35-
with:
36-
fetch-depth: 1
37-
- uses: ./.github/actions/wait-for-smoke
38-
with:
39-
github-token: ${{ secrets.GITHUB_TOKEN }}
40-
4128
cmdtest_test:
42-
needs: wait_for_smoke
4329
if: github.event_name != 'pull_request' || github.event.pull_request.draft == false
4430
name: Command line test
4531
runs-on: ubuntu-22.04

.github/workflows/fips-ready.yml

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -25,21 +25,7 @@ concurrency:
2525
# END OF COMMON SECTION
2626

2727
jobs:
28-
wait_for_smoke:
29-
name: Wait for smoke
30-
if: github.event_name != 'pull_request' || github.event.pull_request.draft == false
31-
runs-on: ubuntu-22.04
32-
timeout-minutes: 35
33-
steps:
34-
- uses: actions/checkout@v4
35-
with:
36-
fetch-depth: 1
37-
- uses: ./.github/actions/wait-for-smoke
38-
with:
39-
github-token: ${{ secrets.GITHUB_TOKEN }}
40-
4128
fips_ready_test:
42-
needs: wait_for_smoke
4329
if: github.event_name != 'pull_request' || github.event.pull_request.draft == false
4430
name: FIPS Ready Bundle Test
4531
runs-on: ubuntu-22.04

.github/workflows/multi-compiler.yml

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -25,21 +25,7 @@ concurrency:
2525
# END OF COMMON SECTION
2626

2727
jobs:
28-
wait_for_smoke:
29-
name: Wait for smoke
30-
if: github.event_name != 'pull_request' || github.event.pull_request.draft == false
31-
runs-on: ubuntu-22.04
32-
timeout-minutes: 35
33-
steps:
34-
- uses: actions/checkout@v4
35-
with:
36-
fetch-depth: 1
37-
- uses: ./.github/actions/wait-for-smoke
38-
with:
39-
github-token: ${{ secrets.GITHUB_TOKEN }}
40-
4128
build_wolfprovider:
42-
needs: wait_for_smoke
4329
if: github.event_name != 'pull_request' || github.event.pull_request.draft == false
4430
name: Build with compiler ${{ matrix.CC }}, wolfssl ${{ matrix.wolfssl_ref }}, OpenSSL ${{ matrix.openssl_ref }}
4531
runs-on: ${{ matrix.OS }}

.github/workflows/openssl-version.yml

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -25,25 +25,12 @@ concurrency:
2525
# END OF COMMON SECTION
2626

2727
jobs:
28-
wait_for_smoke:
29-
name: Wait for smoke
30-
if: github.event_name != 'pull_request' || github.event.pull_request.draft == false
31-
runs-on: ubuntu-22.04
32-
timeout-minutes: 35
33-
steps:
34-
- uses: actions/checkout@v4
35-
with:
36-
fetch-depth: 1
37-
- uses: ./.github/actions/wait-for-smoke
38-
with:
39-
github-token: ${{ secrets.GITHUB_TOKEN }}
40-
4128
discover_versions:
4229
if: github.event_name != 'pull_request' || github.event.pull_request.draft == false
4330
uses: ./.github/workflows/_discover-versions.yml
4431

4532
openssl_version_test:
46-
needs: [wait_for_smoke, discover_versions]
33+
needs: discover_versions
4734
if: github.event_name != 'pull_request' || github.event.pull_request.draft == false
4835
continue-on-error: true
4936
name: OpenSSL Version Test

.github/workflows/sanitizers.yml

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -35,25 +35,12 @@ concurrency:
3535
# END OF COMMON SECTION
3636

3737
jobs:
38-
wait_for_smoke:
39-
name: Wait for smoke
40-
if: github.event_name != 'pull_request' || github.event.pull_request.draft == false
41-
runs-on: ubuntu-22.04
42-
timeout-minutes: 35
43-
steps:
44-
- uses: actions/checkout@v4
45-
with:
46-
fetch-depth: 1
47-
- uses: ./.github/actions/wait-for-smoke
48-
with:
49-
github-token: ${{ secrets.GITHUB_TOKEN }}
50-
5138
discover_versions:
5239
if: github.event_name != 'pull_request' || github.event.pull_request.draft == false
5340
uses: ./.github/workflows/_discover-versions.yml
5441

5542
sanitizers:
56-
needs: [wait_for_smoke, discover_versions]
43+
needs: discover_versions
5744
if: github.event_name != 'pull_request' || github.event.pull_request.draft == false
5845
name: ASan+UBSan (wolfSSL ${{ needs.discover_versions.outputs.wolfssl_ref }} / ${{ needs.discover_versions.outputs.openssl_ref }})
5946
runs-on: ubuntu-22.04

.github/workflows/seed-src.yml

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -25,21 +25,7 @@ concurrency:
2525
# END OF COMMON SECTION
2626

2727
jobs:
28-
wait_for_smoke:
29-
name: Wait for smoke
30-
if: github.event_name != 'pull_request' || github.event.pull_request.draft == false
31-
runs-on: ubuntu-22.04
32-
timeout-minutes: 35
33-
steps:
34-
- uses: actions/checkout@v4
35-
with:
36-
fetch-depth: 1
37-
- uses: ./.github/actions/wait-for-smoke
38-
with:
39-
github-token: ${{ secrets.GITHUB_TOKEN }}
40-
4128
seed_src_test:
42-
needs: wait_for_smoke
4329
if: github.event_name != 'pull_request' || github.event.pull_request.draft == false
4430
name: SEED-SRC Test
4531
runs-on: ubuntu-22.04

.github/workflows/simple.yml

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -25,25 +25,12 @@ concurrency:
2525
# END OF COMMON SECTION
2626

2727
jobs:
28-
wait_for_smoke:
29-
name: Wait for smoke
30-
if: github.event_name != 'pull_request' || github.event.pull_request.draft == false
31-
runs-on: ubuntu-22.04
32-
timeout-minutes: 35
33-
steps:
34-
- uses: actions/checkout@v4
35-
with:
36-
fetch-depth: 1
37-
- uses: ./.github/actions/wait-for-smoke
38-
with:
39-
github-token: ${{ secrets.GITHUB_TOKEN }}
40-
4128
discover_versions:
4229
if: github.event_name != 'pull_request' || github.event.pull_request.draft == false
4330
uses: ./.github/workflows/_discover-versions.yml
4431

4532
simple_test:
46-
needs: [wait_for_smoke, discover_versions]
33+
needs: discover_versions
4734
if: github.event_name != 'pull_request' || github.event.pull_request.draft == false
4835
name: Simple Test
4936
runs-on: ubuntu-22.04

0 commit comments

Comments
 (0)