Skip to content

Temporary test fix due to changing behavior in openssl master#120

Merged
dgarske merged 1 commit into
wolfSSL:masterfrom
ColtonWilley:wp_temp_fix_hkdf_test_fail
Apr 28, 2025
Merged

Temporary test fix due to changing behavior in openssl master#120
dgarske merged 1 commit into
wolfSSL:masterfrom
ColtonWilley:wp_temp_fix_hkdf_test_fail

Conversation

@ColtonWilley

Copy link
Copy Markdown
Contributor

This PR for openssl openssl/openssl#27305 went into master, changing expected return codes. Only run tests for older versions until this can be worked out with the openssl maintainers.

@padelsbach

Copy link
Copy Markdown
Contributor

LGTM. Any more details on what the specific incompatibility is?

@ColtonWilley

Copy link
Copy Markdown
Contributor Author

LGTM. Any more details on what the specific incompatibility is?

Yes, previous behavior that allowed setting a salt of NULL/0 has been changed to now error on that case.

@padelsbach

Copy link
Copy Markdown
Contributor

LGTM. Any more details on what the specific incompatibility is?

Yes, previous behavior that allowed setting a salt of NULL/0 has been changed to now error on that case.

Is this the problematic call in test_hkdf_calc?

        if (EVP_PKEY_derive(ctx, key, &len) != 1) {
            err = 1;
        }

@dgarske dgarske merged commit e48872f into wolfSSL:master Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants