Skip to content

libwebsockets.yml Github workflow#161

Merged
padelsbach merged 1 commit into
wolfSSL:masterfrom
BridgerVoss:libwebsockets
Jun 19, 2025
Merged

libwebsockets.yml Github workflow#161
padelsbach merged 1 commit into
wolfSSL:masterfrom
BridgerVoss:libwebsockets

Conversation

@BridgerVoss
Copy link
Copy Markdown

Added Github workflow for libwebsockets OSP

  • tests pass as expected

Comment thread .github/workflows/libwebsockets.yml Outdated
Comment thread .github/workflows/libwebsockets.yml Outdated
Comment thread .github/scripts/check-workflow-result.sh Outdated
Comment thread .github/scripts/check-workflow-result.sh Outdated
Copy link
Copy Markdown
Member

@aidangarske aidangarske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

Comment thread .github/workflows/libwebsockets.yml Outdated
Comment thread .github/workflows/libwebsockets.yml Outdated
Comment thread .github/workflows/libwebsockets.yml Outdated
padelsbach
padelsbach previously approved these changes Jun 11, 2025
Copy link
Copy Markdown
Contributor

@padelsbach padelsbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks

Comment thread .github/workflows/libwebsockets.yml Outdated
aidangarske
aidangarske previously approved these changes Jun 11, 2025
@BridgerVoss BridgerVoss requested a review from padelsbach June 12, 2025 14:57
Comment thread .github/scripts/check-workflow-result.sh Outdated
Comment thread .github/workflows/libwebsockets.yml Outdated
Comment thread .github/workflows/libwebsockets.yml Outdated
Comment thread .github/workflows/libwebsockets.yml Outdated
Comment thread .github/workflows/libwebsockets.yml Outdated
Comment thread .github/workflows/libwebsockets.yml Outdated
@BridgerVoss BridgerVoss force-pushed the libwebsockets branch 3 times, most recently from 107571f to 5c4e449 Compare June 13, 2025 15:55
Copy link
Copy Markdown
Contributor

@padelsbach padelsbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. A few more questions. And it looks like the test is failing, can you investigate?

Comment thread .github/workflows/libwebsockets.yml Outdated
Comment thread .github/workflows/libwebsockets.yml Outdated
Comment thread .github/workflows/libwebsockets.yml Outdated
@BridgerVoss BridgerVoss force-pushed the libwebsockets branch 2 times, most recently from 4d74441 to c32d7bd Compare June 13, 2025 17:19
padelsbach
padelsbach previously approved these changes Jun 13, 2025
Copy link
Copy Markdown
Contributor

@padelsbach padelsbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done!

aidangarske
aidangarske previously approved these changes Jun 13, 2025
@BridgerVoss BridgerVoss removed their assignment Jun 13, 2025
Comment thread .github/workflows/libwebsockets.yml Outdated
Comment thread .github/workflows/libwebsockets.yml Outdated
Comment thread .github/workflows/libwebsockets.yml Outdated
@padelsbach padelsbach merged commit 5bc0a6f into wolfSSL:master Jun 19, 2025
148 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants