Skip to content

libhashkit2 yml workflow#175

Closed
BridgerVoss wants to merge 1 commit into
wolfSSL:masterfrom
BridgerVoss:libhashkit
Closed

libhashkit2 yml workflow#175
BridgerVoss wants to merge 1 commit into
wolfSSL:masterfrom
BridgerVoss:libhashkit

Conversation

@BridgerVoss

@BridgerVoss BridgerVoss commented Jun 16, 2025

Copy link
Copy Markdown

Added wolfProvider tests for libhashkit2 which is a part of the bigger repository, libmemcached.

  • libhashkit is passing all tests now as expected with updated wolfProvider

@BridgerVoss BridgerVoss changed the title (WIP) libhashkit2 yml workflow libhashkit2 yml workflow Jul 7, 2025
@BridgerVoss BridgerVoss marked this pull request as ready for review July 7, 2025 16:21
@BridgerVoss

Copy link
Copy Markdown
Author

retest this please jenkins

@aidangarske aidangarske left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks

@aidangarske aidangarske requested a review from ColtonWilley July 9, 2025 17:50

@aidangarske aidangarske left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually @BridgerVoss, it looks like you and Paul have conflicting PR's. Can we close in favor of #195?

@BridgerVoss

Copy link
Copy Markdown
Author

Actually @BridgerVoss, it looks like you and Paul have conflicting PR's. Can we close in favor of #195?

@aidangarske yeah that's fine as long TEST_RESULT=2 is okay as that is what Makefile returns on force fail in #195 . Doesn't really matter logic wise just didn't know if we want that for consistency or not

@aidangarske

Copy link
Copy Markdown
Member

Okay ya I see that I will fix it in 195

@BridgerVoss BridgerVoss closed this Jul 9, 2025
@BridgerVoss

Copy link
Copy Markdown
Author

continued in #195

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants