Fix RSA decode and empty Keygen OID with FIPS#196
Merged
Conversation
ColtonWilley
reviewed
Jul 3, 2025
aidangarske
force-pushed
the
rsa_decode_fix
branch
from
596b938 to
9e90eb8
Compare
ColtonWilley
reviewed
Jul 9, 2025
ColtonWilley
approved these changes
Jul 9, 2025
Member
Author
|
Jenkins retest this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
WOLFSSL_OLD_OID_SUMwhich is needed with FIPS v5.2.1 which uses old OID logic. (Fixes errors with OID not being propagated with FIPS)wc_GetPkcs8TraditionalOffsetwith FIPS because keys are created and wrapped in PKCS8 encoding. This removes so we can decode correctly. (Fixes errors with decode in RSA FIPS)WOLFSSL_DEBUG_ASN_TEMPLATE=1option to enableWOLFSSL_DEBUG_ASN_TEMPLATEto help developers debug. Useful for ASN.1 parsing debugAdds WOLFPROV_DISABLE_ERR_TRACEoptions to remove error trace with debug.outuninitialized value