Fix ECC public key validation#207
Closed
ColtonWilley wants to merge 0 commit into
Closed
Conversation
SparkiDev
requested changes
Jul 3, 2025
padelsbach
previously approved these changes
Jul 3, 2025
Contributor
padelsbach
left a comment
padelsbach
left a comment
There was a problem hiding this comment.
Looks good, nice comments. Couple questions/concerns
SparkiDev
requested changes
Jul 7, 2025
Contributor
SparkiDev
left a comment
SparkiDev
left a comment
There was a problem hiding this comment.
I can't see the assignment to public key.
Contributor
Author
|
Retest this please. |
SparkiDev
previously approved these changes
Jul 8, 2025
ColtonWilley
dismissed
SparkiDev’s stale review
The merge-base changed after approval.
aidangarske
previously approved these changes
Jul 15, 2025
ColtonWilley
dismissed
aidangarske’s stale review
The merge-base changed after approval.
aidangarske
previously approved these changes
Jul 15, 2025
ColtonWilley
dismissed
aidangarske’s stale review
The merge-base changed after approval.
aidangarske
force-pushed
the
wp_ecc_pubkey_validate_fix
branch
from
732c9fc to
7307a6a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix an issue with ECC public key validation. When asked to validate the public key, if a private key is present we also check the public against the private. This does not work for a KRB5 use case where there is a private value leftover from the original key the key being used was duped from. In this case the public and private keys do not match up, which is fine because we only need to check the private. Needed a bit of logic to trick wolfCrypt into doing ECC public key only validation.