Skip to content

Update command line tests#245

Merged
ColtonWilley merged 1 commit into
wolfSSL:masterfrom
padelsbach:wp_cmd_test_refactor
Aug 6, 2025
Merged

Update command line tests#245
ColtonWilley merged 1 commit into
wolfSSL:masterfrom
padelsbach:wp_cmd_test_refactor

Conversation

@padelsbach

@padelsbach padelsbach commented Aug 5, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

This update is needed for PR #234

  • Update simple.yml to use newer WP build process
  • Remove build step from the scripts/cmd_test test suite to speed things up (by removing calls to init_openssl and init_wolfssl)
  • Allow caller to provide their own openssl binary
  • DRY out several blocks of repeated code

@padelsbach
padelsbach force-pushed the wp_cmd_test_refactor branch 11 times, most recently from e13d9a1 to badf4b5 Compare August 5, 2025 17:22
@padelsbach padelsbach changed the title Decouple wolfprovider build from command line tests Update command line tests Aug 5, 2025
@padelsbach
padelsbach requested a review from aidangarske August 5, 2025 18:10
@padelsbach
padelsbach marked this pull request as ready for review August 5, 2025 18:10
@padelsbach
padelsbach force-pushed the wp_cmd_test_refactor branch from badf4b5 to e5e10ad Compare August 5, 2025 18:12
@padelsbach padelsbach mentioned this pull request Aug 5, 2025
Merged
aidangarske
aidangarske reviewed Aug 5, 2025
View reviewed changes
Comment thread .github/workflows/simple.yml Outdated
aidangarske
aidangarske reviewed Aug 5, 2025
View reviewed changes

@aidangarske aidangarske left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this looks a lot cleaner now

Comment thread .github/workflows/simple.yml Outdated
Comment thread scripts/cmd_test/do-cmd-tests.sh Outdated
Comment thread scripts/cmd_test/cmd-test-common.sh Outdated
Comment thread scripts/cmd_test/do-cmd-tests.sh Outdated
Comment thread scripts/cmd_test/ecc-cmd-test.sh Outdated
@padelsbach
padelsbach force-pushed the wp_cmd_test_refactor branch 3 times, most recently from 46494c7 to ff233d0 Compare August 5, 2025 22:12
aidangarske
aidangarske reviewed Aug 6, 2025
View reviewed changes
Comment thread scripts/cmd_test/ecc-cmd-test.sh Outdated
@padelsbach
padelsbach force-pushed the wp_cmd_test_refactor branch from ff233d0 to d70f96c Compare August 6, 2025 19:48
@ColtonWilley
ColtonWilley merged commit bd00908 into wolfSSL:master Aug 6, 2025
282 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ColtonWilley ColtonWilley ColtonWilley approved these changes
@aidangarske aidangarske aidangarske approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@padelsbach @ColtonWilley @aidangarske