Extending error printing for silent wolfssl errors#268
Merged
Conversation
f826e98 to
6f277c0
Compare
3af9923 to
31b717a
Compare
aidangarske
requested changes
Aug 29, 2025
aidangarske
reviewed
Aug 29, 2025
Member
aidangarske
left a comment
There was a problem hiding this comment.
You should find a place to mention that to see the rc from wolfssl you must add WP_LOG_DEBUG to the WOLFPROV_LOG_LEVEL_FILTER. Perhaps in wp_logging.h like in wolfProv_LogType
43662e0 to
6320177
Compare
Contributor
|
There are now 240 logs of the form Instead, we could add a function in wp_logging.c which unifies this for DRYness and code size. Eg: |
242f493 to
ee4480d
Compare
ee4480d to
4b74109
Compare
aidangarske
approved these changes
Sep 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added WOLFPROV_MSG_DEBUG_RETCODE with the function name that is failing and the rc dump.