Skip to content

ci: trigger publish-test-deps-image on PR Dockerfile changes#403

Merged
dgarske merged 2 commits into
wolfSSL:masterfrom
aidangarske:aidan/bootstrap-publish-pr-trigger
May 27, 2026
Merged

ci: trigger publish-test-deps-image on PR Dockerfile changes#403
dgarske merged 2 commits into
wolfSSL:masterfrom
aidangarske:aidan/bootstrap-publish-pr-trigger

Conversation

@aidangarske
Copy link
Copy Markdown
Member

@aidangarske aidangarske commented May 27, 2026

No description provided.

Adds pull_request_target trigger so a Dockerfile change in a PR
republishes :bookworm without waiting for merge to master. Uses the
PR head SHA in checkout so the build sees the PR's Dockerfile.
Concurrency now scoped per-PR/branch to keep parallel pushes from
racing to overwrite the tag.
Copilot AI review requested due to automatic review settings May 27, 2026 18:36
@aidangarske aidangarske requested a review from dgarske May 27, 2026 18:37
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the publish-test-deps-image GitHub Actions workflow so that changes to docker/wolfprovider-test-deps/** in pull requests can trigger a rebuild/publish of the wolfprovider-test-deps image, enabling PR CI jobs to use updated dependency images.

Changes:

  • Adds a pull_request_target trigger for Dockerfile/workflow path changes.
  • Adjusts checkout to build from the PR head SHA under pull_request_target.
  • Updates concurrency grouping to reduce push races.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/publish-test-deps-image.yml
Comment thread .github/workflows/publish-test-deps-image.yml
Comment thread .github/workflows/publish-test-deps-image.yml
Comment thread .github/workflows/publish-test-deps-image.yml Outdated
…e SHA tag

Addresses Copilot review on wolfSSL#403:

- Author gate: pull_request_target only runs for OWNER/MEMBER. The
  prior 'github.repository == wolfSSL/wolfProvider' check did not
  exclude fork PRs since github.repository on pull_request_target is
  the BASE repo. Without the author gate a fork PR could smuggle a
  Dockerfile RUN that exfiltrates the canonical GITHUB_TOKEN (it has
  packages:write here).
- Concurrency: drop the per-PR group and use a single global group.
  Per-PR serialization still let two PRs race to overwrite the shared
  :bookworm tag.
- SHA tag: on pull_request_target github.sha is the BASE commit, not
  what we actually built. Resolve from the checked-out HEAD so the
  bookworm-<sha> tag matches the image contents.
@dgarske dgarske self-assigned this May 27, 2026
@dgarske dgarske merged commit 3de3a16 into wolfSSL:master May 27, 2026
372 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants