Skip to content

Reset on SPDM runner test#484

Merged
dgarske merged 1 commit into
wolfSSL:masterfrom
aidangarske:spdm-runner-caps-reset
Apr 17, 2026
Merged

Reset on SPDM runner test#484
dgarske merged 1 commit into
wolfSSL:masterfrom
aidangarske:spdm-runner-caps-reset

Conversation

@aidangarske

Copy link
Copy Markdown
Member

Caps is failing because it may be left in bad state

Run EXPECTED='NPCT75x'
TPM2 Get Capabilities
TPM2: Caps 0x00000000, Did 0x0000, Vid 0x0000, Rid 0x 0 
Failed to connect to localhost 2321
TPM2_Startup failed 257: TPM_RC_FAILURE: Commands not being accepted because of a TPM failure
wolfTPM2_Init failed
0s
Run echo "::warning::NPCT75x not detected on SPI CS 0. Skipping nuvoton SPDM tests — wire the chip and re-run, or ignore if this vendor isn't installed on this runner."
Warning: NPCT75x not detected on SPI CS 0. Skipping nuvoton SPDM tests — wire the chip and re-run, or ignore if this vendor isn't installed on this runner.

Copilot AI review requested due to automatic review settings April 17, 2026 16:38

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Ensures the hardware SPDM runner starts from a clean TPM state so capability detection doesn’t fail due to a previously locked/stale TPM state.

Changes:

  • Adds a GPIO reset step before TPM detection to clear shared reset-line state.
  • Broadens post-job cleanup to run whenever the health check succeeds (not only when a device was detected).
  • Makes cleanup unlock/flush commands explicitly error-tolerant when no chip is present.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/hw-spdm-test.yml
Comment thread .github/workflows/hw-spdm-test.yml
Comment thread .github/workflows/hw-spdm-test.yml
@dgarske dgarske merged commit e9c9099 into wolfSSL:master Apr 17, 2026
111 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants