Split hardware SPDM CI across runners#485
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR updates the hardware SPDM GitHub Actions workflow to run vendor-specific jobs on separate self-hosted runners, enabling parallel execution without cross-vendor hardware contention.
Changes:
- Parameterized
runs-onvia a matrix-providedrunner_labelto target dedicated per-vendor runners. - Switched from a single global concurrency lock to per-vendor concurrency groups.
- Removed the pre-detect/warn gating steps and runs the hardware SPDM tests unconditionally when the runner health check passes.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Each vendor now has a dedicated Pi:
- wolftpm-nuvoton: NPCT75x on SPI CS 0 (existing runner, relabeled)
- wolftpm-nations: NS350 on SPI CS 0 (new runner rpi-ns350)
Changes:
- runs-on uses matrix.runner_label so each matrix entry routes to
the correct physical runner.
- Concurrency moved from workflow-level to job-level with group
hw-spdm-runner-${{ matrix.vendor }} so nuvoton and nations run in
parallel rather than serializing on a shared hw-spdm-runner group.
- Dropped the pre-test caps detect step and its GPIO 4 reset pulse.
The detect step was unreliable (auto-SPDM in wolfTPM2_Init only
fires on TPM_RC_DISABLED from Startup, not TPM_RC_FAILURE, so a
locked chip couldn't self-recover) and pointless now that each
runner is dedicated to a known chip. spdm_test.sh already handles
its own vendor-specific reset: gpio_reset for nuvoton, no-reset
for nations (GPIO 4 isn't routed to NS350 RST on the daughter
board, per spdm_test.sh:135,159).
- Nations spi_cs flipped from 1 to 0 since the new Pi has NS350 on
its own CS 0 rather than sharing a bus with NPCT75x.
aidangarske
force-pushed
the
spdm-split-runners-v2
branch
from
ea1c206 to
de47fd5
Compare
dgarske
approved these changes
Apr 17, 2026
Member
|
Merging with CI issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.