Address review comments, fix bugs, add tests

- ioctl(): read vararg as void* to avoid UB when callers pass pointers
- bsd_socket.c: fix errno assignments to use -ret (positive) per POSIX
- bsd_socket.c: use -WOLFIP_EAGAIN instead of -EAGAIN in recvfrom
- wolfip.c: fix packet socket TX filter loop to pop head on reject
  instead of advancing via fifo_next() (queue corruption fix)
- wolfip.c: return -WOLFIP_EMSGSIZE on buffer-too-small in recvfrom
  for raw, packet, and ICMP socket paths
- wolfip.c: packet setsockopt now rejects unsupported options with
  -WOLFIP_EINVAL instead of silently succeeding
- wolfip.c: getsockopt RECVTTL returns enabled state (1/0), not TTL
- wolfip.c: arp_lookup_ex returns -WOLFIP_ENOENT on miss
- wolfip.h: add WOLFIP_EMSGSIZE and WOLFIP_ENOENT error codes
- wolfip.c: fix IS_IP_BCAST -> wolfIP_ip_is_broadcast() after rebase
- Add 7 new unit tests covering EMSGSIZE paths, setsockopt rejection,
  raw socket options, getsockopt behavior, packet TX via poll, and
  arp_lookup_ex error codes
- Update existing tests to match new error return values

Author: danielinux

src/port/posix/bsd_socket.c

@@ -1237,24 +1237,22 @@ int wolfIP_sock_select(struct wolfIP *ipstack, int nfds, fd_set *readfds, fd_set
 int ioctl(int fd, unsigned long request, ...)
 {
     va_list ap;
-    uintptr_t arg;
     void *argp;
     struct ifreq *ifr;
     int i;
 
     va_start(ap, request);
-    arg = va_arg(ap, uintptr_t);
+    argp = va_arg(ap, void *);
     va_end(ap);
-    argp = (void *)arg;
 
     if (in_the_stack) {
-        return host_ioctl ? host_ioctl(fd, request, arg) : -1;
+        return host_ioctl ? host_ioctl(fd, request, argp) : -1;
     }
 
     if (request == SIOCGIFINDEX || request == SIOCGIFHWADDR || request == SIOCGIFADDR) {
         struct wolfip_fd_entry *entry = wolfip_entry_from_public(fd);
         if (!entry) {
-            return host_ioctl ? host_ioctl(fd, request, arg) : -1;
+            return host_ioctl ? host_ioctl(fd, request, argp) : -1;
         }
         ifr = (struct ifreq *)argp;
         if (!ifr) {
@@ -1330,7 +1328,7 @@ int ioctl(int fd, unsigned long request, ...)
         return 0;
     }
 
-    return host_ioctl ? host_ioctl(fd, request, arg) : -1;
+    return host_ioctl ? host_ioctl(fd, request, argp) : -1;
 }
 
 int select(int nfds, fd_set *readfds, fd_set *writefds, fd_set *exceptfds, struct timeval *timeout) {
@@ -1402,7 +1400,7 @@ int bind(int sockfd, const struct sockaddr *addr, socklen_t addrlen) {
                         (const struct wolfIP_sockaddr *)addr, addrlen);
             }
             if (ret < 0) {
-                errno = ret;
+                errno = -ret;
                 pthread_mutex_unlock(&wolfIP_mutex);
                 return -1;
             }
@@ -1445,7 +1443,7 @@ int close(int sockfd) {
         wolfip_fd_release(sockfd);
         ret = wolfIP_sock_close(IPSTACK, internal_fd);
         if (ret < 0) {
-            errno = ret;
+            errno = -ret;
             pthread_mutex_unlock(&wolfIP_mutex);
             return -1;
         }
@@ -1502,7 +1500,7 @@ static int wolfip_accept_common(int sockfd, struct sockaddr *addr, socklen_t *ad
             }
         } while (internal_ret == -EAGAIN);
         if (internal_ret < 0) {
-            errno = internal_ret;
+            errno = -internal_ret;
             pthread_mutex_unlock(&wolfIP_mutex);
             return -1;
         }
@@ -1556,7 +1554,7 @@ ssize_t recvfrom(int sockfd, void *buf, size_t len, int flags, struct sockaddr *
                     pthread_mutex_unlock(&wolfIP_mutex);
                     return ret;
                 }
-                if (ret != -EAGAIN)
+                if (ret != -WOLFIP_EAGAIN)
                     break;
                 if (nonblock) {
                     errno = EAGAIN;
@@ -1577,7 +1575,7 @@ ssize_t recvfrom(int sockfd, void *buf, size_t len, int flags, struct sockaddr *
                     pthread_mutex_lock(&wolfIP_mutex);
                 }
             } while (1);
-            errno = ret;
+            errno = -ret;
             pthread_mutex_unlock(&wolfIP_mutex);
             return -1;
         } else {

src/test/unit/unit.c

@@ -708,6 +708,13 @@ Suite *wolf_suite(void)
     tcase_add_test(tc_proto, test_udp_short_frame_does_not_overread);
     tcase_add_test(tc_proto, test_raw_socket_close_clears_entry);
     tcase_add_test(tc_proto, test_packet_socket_close_clears_entry);
+    tcase_add_test(tc_proto, test_raw_socket_recv_emsgsize);
+    tcase_add_test(tc_proto, test_packet_socket_recv_emsgsize);
+    tcase_add_test(tc_proto, test_packet_socket_setsockopt_rejected);
+    tcase_add_test(tc_proto, test_raw_socket_setsockopt_options);
+    tcase_add_test(tc_proto, test_raw_socket_getsockopt_recvttl);
+    tcase_add_test(tc_proto, test_packet_socket_poll_sends_frame);
+    tcase_add_test(tc_proto, test_arp_lookup_ex_errors);
     tcase_add_test(tc_proto, test_arp_lookup_ex_basic);
     tcase_add_test(tc_proto, test_wolfip_recv_on_not_for_us);
     tcase_add_test(tc_proto, test_wolfip_recv_on_filter_drop_eth);

src/test/unit/unit_tests_dns_dhcp.c

@@ -1465,7 +1465,7 @@ START_TEST(test_sock_recvfrom_icmp_paths)
     ck_assert_ptr_nonnull(desc);
 
     ret = wolfIP_sock_recvfrom(&s, icmp_sd, rxbuf, (size_t)(ICMP_HEADER_LEN - 1), 0, NULL, NULL);
-    ck_assert_int_eq(ret, -1);
+    ck_assert_int_eq(ret, -WOLFIP_EMSGSIZE);
 
     ret = wolfIP_sock_recvfrom(&s, icmp_sd, rxbuf, sizeof(rxbuf), 0, NULL, NULL);
     ck_assert_int_eq(ret, -WOLFIP_EAGAIN);
@@ -1690,7 +1690,7 @@ START_TEST(test_sock_recvfrom_icmp_payload_too_long)
     fifo_push(&ts->sock.udp.rxbuf, &icmp, sizeof(icmp));
 
     ret = wolfIP_sock_recvfrom(&s, icmp_sd, rxbuf, sizeof(rxbuf), 0, NULL, NULL);
-    ck_assert_int_eq(ret, -1);
+    ck_assert_int_eq(ret, -WOLFIP_EMSGSIZE);
 }
 END_TEST