fix new scan-build warning

Author: JacobBarthelmeh

apps/wolfsshd/wolfsshd.c

@@ -780,6 +780,11 @@ int main(int argc, char** argv)
 
             case 'p':
                 if (ret == WS_SUCCESS) {
+                    if (myoptarg == NULL) {
+                        ret = WS_BAD_ARGUMENT;
+                        break;
+                    }
+
                     ret = XATOI(myoptarg);
                     if (ret < 0) {
                         fprintf(stderr, "Issue parsing port number %s\n",

examples/echoserver/echoserver.c

@@ -747,7 +747,7 @@ static int ssh_worker(thread_ctx_t* threadCtx)
                 if (agentListenFd > maxFd)
                     maxFd = agentListenFd;
             }
-            if (threadCtx->agentCbCtx.state == AGENT_STATE_CONNECTED) {
+            if (agentFd >= 0 && threadCtx->agentCbCtx.state == AGENT_STATE_CONNECTED) {
                 FD_SET(agentFd, &readFds);
                 if (agentFd > maxFd)
                     maxFd = agentFd;
@@ -759,7 +759,7 @@ static int ssh_worker(thread_ctx_t* threadCtx)
                 if (fwdListenFd > maxFd)
                     maxFd = fwdListenFd;
             }
-            if (threadCtx->fwdCbCtx.state == FWD_STATE_CONNECTED) {
+            if (fwdFd >= 0 && threadCtx->fwdCbCtx.state == FWD_STATE_CONNECTED) {
                 FD_SET(fwdFd, &readFds);
                 if (fwdFd > maxFd)
                     maxFd = fwdFd;
@@ -918,7 +918,7 @@ static int ssh_worker(thread_ctx_t* threadCtx)
             }
             #endif
             #ifdef WOLFSSH_AGENT
-            if (threadCtx->agentCbCtx.state == AGENT_STATE_CONNECTED) {
+            if (agentFd >= 0 && threadCtx->agentCbCtx.state == AGENT_STATE_CONNECTED) {
                 if (FD_ISSET(agentFd, &readFds)) {
                     #ifdef SHELL_DEBUG
                         printf("agentFd set in readfd\n");
@@ -979,7 +979,7 @@ static int ssh_worker(thread_ctx_t* threadCtx)
             }
             #endif
             #ifdef WOLFSSH_FWD
-            if (threadCtx->fwdCbCtx.state == FWD_STATE_CONNECTED) {
+            if (fwdFd >= 0 && threadCtx->fwdCbCtx.state == FWD_STATE_CONNECTED) {
                 if (FD_ISSET(fwdFd, &readFds)) {
                     #ifdef SHELL_DEBUG
                         printf("fwdFd set in readfd\n");

examples/portfwd/portfwd.c

@@ -271,6 +271,8 @@ THREAD_RETURN WOLFSSH_THREAD portfwd_worker(void* args)
                 break;
 
             case 'p':
+                if (myoptarg == NULL)
+                    err_sys("null argument found");
                 port = (word16)atoi(myoptarg);
                 #if !defined(NO_MAIN_DRIVER) || defined(USE_WINDOWS_API)
                     if (port == 0)

examples/scpclient/scpclient.c

@@ -277,6 +277,9 @@ THREAD_RETURN WOLFSSH_THREAD scp_client(void* args)
                 break;
 
             case 'p':
+                if (myoptarg == NULL)
+                    err_sys("null argument found");
+
                 port = (word16)atoi(myoptarg);
                 #if !defined(NO_MAIN_DRIVER) || defined(USE_WINDOWS_API)
                     if (port == 0)

examples/sftpclient/sftpclient.c

@@ -1361,6 +1361,8 @@ THREAD_RETURN WOLFSSH_THREAD sftpclient_test(void* args)
                 break;
 
             case 'p':
+                if (myoptarg == NULL)
+                    err_sys("null argument found");
                 port = (word16)atoi(myoptarg);
                 #if !defined(NO_MAIN_DRIVER) || defined(USE_WINDOWS_API)
                     if (port == 0)