Fix CI

Author: aidangarske

apps/wolfssh/wolfssh.c

@@ -599,7 +599,7 @@ static int wolfSSH_AGENT_DefaultActions(WS_AgentCbAction action, void* vCtx)
         if (ret == WS_AGENT_SUCCESS) {
             WMEMSET(name, 0, sizeof(struct sockaddr_un));
             name->sun_family = AF_LOCAL;
-            WSTRNCPY(name->sun_path, sockName, sizeof(name->sun_path));
+            WSTRNCPY(name->sun_path, sockName, sizeof(name->sun_path) - 1);
             name->sun_path[sizeof(name->sun_path) - 1] = '\0';
             size = WSTRLEN(sockName) +
                     offsetof(struct sockaddr_un, sun_path);
@@ -1046,7 +1046,7 @@ static THREAD_RETURN WOLFSSH_THREAD wolfSSH_Client(void* args)
 
 #if !defined(SINGLE_THREADED) && !defined(WOLFSSL_NUCLEUS)
 #if 0
-    if (keepOpen) /* set up for psuedo-terminal */
+    if (keepOpen) /* set up for pseudo-terminal */
         ClientSetEcho(2);
 #endif
 

examples/client/client.c

@@ -1020,7 +1020,7 @@ THREAD_RETURN WOLFSSH_THREAD client_test(void* args)
 
 #if !defined(SINGLE_THREADED) && !defined(WOLFSSL_NUCLEUS) && \
     defined(WOLFSSH_TERM) && !defined(NO_FILESYSTEM)
-    if (keepOpen) /* set up for psuedo-terminal */
+    if (keepOpen) /* set up for pseudo-terminal */
         ClientSetEcho(2);
 
     if (cmd != NULL || keepOpen == 1) {

examples/echoserver/echoserver.c

@@ -2504,7 +2504,7 @@ static void ShowUsage(void)
            "               add password to accept from peer\n");
 #ifdef WOLFSSH_KEYBOARD_INTERACTIVE
     printf(" -i <name>:<password>\n"
-           "               add password to accept via keyboard-interactive"
+           "               add password to accept via keyboard-interactive "
            "from peer\n");
 #endif
 #ifdef WOLFSSH_CERTS

tests/api.c

@@ -1240,7 +1240,11 @@ static void test_wolfSSH_SFTP_SendReadPacket(void)
         }
 
         if (tmp != NULL) {
-            out = (byte*)malloc(tmp->atrb.sz[0]);
+            /* Allocate buffer large enough for maximum read size */
+            word32 allocSz = tmp->atrb.sz[0];
+            if (allocSz < WOLFSSH_MAX_SFTP_RW)
+                allocSz = WOLFSSH_MAX_SFTP_RW;
+            out = (byte*)malloc(allocSz);
             AssertIntEQ(wolfSSH_SFTP_Open(ssh, tmp->fName, WOLFSSH_FXF_READ,
                         NULL, handle, &handleSz), WS_SUCCESS);