Debug

Author: yosuke-wolfssl

.github/workflows/windows-check.yml

@@ -183,6 +183,13 @@ jobs:
         $cfg = "${{env.WOLFSSH_BUILD_CONFIGURATION}}\${{env.BUILD_PLATFORM}}"
         $dll = Join-Path $env:ASAN_BIN_DIR "clang_rt.asan_dynamic-x86_64.dll"
         if (-not (Test-Path $dll)) { throw "ASAN runtime DLL not found: $dll" }
+        # Fetch procdump so a hard crash (__fastfail / 0xC0000409 from /GS or a
+        # CRT invalid-parameter abort) can be captured as a full dump. Such a
+        # crash bypasses the ASan exit path and leaves no report of its own.
+        Invoke-WebRequest -Uri "https://download.sysinternals.com/files/Procdump.zip" -OutFile procdump.zip
+        Expand-Archive -Force procdump.zip -DestinationPath procdump
+        $procdump = "procdump\procdump64.exe"
+        New-Item -ItemType Directory -Force -Path dumps | Out-Null
         foreach ($t in @("api-test", "unit-test")) {
           $dir = "ide\winvs\$t\$cfg"
           # Static signal: confirm the binary really imports the ASan runtime, so
@@ -193,6 +200,41 @@ jobs:
           ($deps -split "`n" | Select-String "asan").Line.Trim() | ForEach-Object { Write-Host "  $_" }
           Copy-Item $dll $dir
           & "$dir\$t.exe"
-          if ($LASTEXITCODE -ne 0) { throw "$t failed under ASAN (exit $LASTEXITCODE)" }
+          $code = $LASTEXITCODE
+          if ($code -ne 0) {
+            # Re-run under procdump (attaches as a debugger, so it sees the
+            # __fastfail) to capture a full dump next to the .pdb for offline
+            # analysis. The diagnostic markers printed above already identify the
+            # last test reached.
+            Write-Host "$t exited $code; re-running under procdump to capture a crash dump"
+            & $procdump -accepteula -ma -e -x dumps "$dir\$t.exe"
+            Copy-Item "$dir\$t.pdb" dumps -ErrorAction SilentlyContinue
+            Copy-Item "$dir\$t.exe" dumps -ErrorAction SilentlyContinue
+            # Symbolicate the faulting stack here on the runner, where every PDB
+            # (api-test, wolfssh, wolfssl) and the MS symbol server are reachable,
+            # so the crash location lands directly in this log.
+            $cdb = Get-ChildItem `
+              "C:\Program Files (x86)\Windows Kits\10\Debuggers\x64\cdb.exe", `
+              "C:\Program Files\Windows Kits\10\Debuggers\x64\cdb.exe" `
+              -ErrorAction SilentlyContinue | Select-Object -First 1
+            $dmp = Get-ChildItem dumps\*.dmp -ErrorAction SilentlyContinue | Select-Object -First 1
+            if ($cdb -and $dmp) {
+              $sym = "srv*https://msdl.microsoft.com/download/symbols;$PWD\$dir;$PWD\ide\winvs\wolfssh\$cfg;$PWD\..\wolfssl\$cfg"
+              Write-Host "==== cdb !analyze of $($dmp.Name) ===="
+              & $cdb.FullName -z $dmp.FullName -y $sym -c ".ecxr; !analyze -v; kb; q"
+            }
+            else {
+              Write-Host "cdb or dump not found; skipping on-runner analysis (cdb='$cdb' dmp='$dmp')"
+            }
+            throw "$t failed under ASAN (exit $code)"
+          }
         }
 
+    - name: Upload crash dumps
+      if: always()
+      uses: actions/upload-artifact@v4
+      with:
+        name: windows-asan-crash-dumps
+        path: wolfssh/dumps
+        if-no-files-found: ignore
+

tests/api.c

@@ -3755,23 +3755,37 @@ int wolfSSH_ApiTest(int argc, char** argv)
 #endif
 
     /* SCP tests */
+    printf("== running test_wolfSSH_SCP_CB\n"); WFFLUSH(stdout);
     test_wolfSSH_SCP_CB();
+    printf("== running test_wolfSSH_SCP_SendSymlinkReject\n"); WFFLUSH(stdout);
     test_wolfSSH_SCP_SendSymlinkReject();
+    printf("== running test_wolfSSH_SCP_ReKey\n"); WFFLUSH(stdout);
     test_wolfSSH_SCP_ReKey();
+    printf("== running test_wolfSSH_SCP_ReKey_NonBlock\n"); WFFLUSH(stdout);
     test_wolfSSH_SCP_ReKey_NonBlock();
+    printf("== running test_wolfSSH_SCP_ReKey_ToServer\n"); WFFLUSH(stdout);
     test_wolfSSH_SCP_ReKey_ToServer();
+    printf("== running test_wolfSSH_SCP_ReKey_ToServer_NonBlock\n"); WFFLUSH(stdout);
     test_wolfSSH_SCP_ReKey_ToServer_NonBlock();
 
     /* SFTP tests */
+    printf("== running test_wolfSSH_SFTP_SendReadPacket\n"); WFFLUSH(stdout);
     test_wolfSSH_SFTP_SendReadPacket();
+    printf("== running test_wolfSSH_SFTP_PartialSend\n"); WFFLUSH(stdout);
     test_wolfSSH_SFTP_PartialSend();
+    printf("== running test_wolfSSH_SFTP_ReKey\n"); WFFLUSH(stdout);
     test_wolfSSH_SFTP_ReKey();
+    printf("== running test_wolfSSH_SFTP_ReKey_NonBlock\n"); WFFLUSH(stdout);
     test_wolfSSH_SFTP_ReKey_NonBlock();
+    printf("== running test_wolfSSH_SFTP_Confinement\n"); WFFLUSH(stdout);
     test_wolfSSH_SFTP_Confinement();
+    printf("== running test_wolfSSH_SFTP_SetDefaultPath\n"); WFFLUSH(stdout);
     test_wolfSSH_SFTP_SetDefaultPath();
 
     /* Either SCP or SFTP */
+    printf("== running test_wolfSSH_RealPath\n"); WFFLUSH(stdout);
     test_wolfSSH_RealPath();
+    printf("== all api tests completed\n"); WFFLUSH(stdout);
     AssertIntEQ(wolfSSH_Cleanup(), WS_SUCCESS);
 
     return 0;