Test: Add validation for service request/accept (Jenkins supervisor test)#907
Open
ColtonWilley wants to merge 2 commits intowolfSSL:masterfrom
Open
Test: Add validation for service request/accept (Jenkins supervisor test)#907ColtonWilley wants to merge 2 commits intowolfSSL:masterfrom
ColtonWilley wants to merge 2 commits intowolfSSL:masterfrom
Conversation
Validates that the requested/accepted service in DoServiceRequest and DoServiceAccept is 'ssh-userauth', disconnecting if not. Includes intentional Windows build error for Jenkins supervisor testing.
Remove the #error directive (wrong compilation unit for Windows). Add test_wolfSSH_ServiceRequestValidation using a variable-length array which GCC/Clang accept but MSVC rejects, ensuring the Windows Jenkins job fails while Linux jobs pass.
Author
|
Jenkins retest this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DoServiceRequestandDoServiceAcceptto ensure the requested/accepted service isssh-userauth, disconnecting otherwise (mirrors PR Add validation for accept request and reply #902)#errorin aUSE_WINDOWS_APIblock to trigger a Windows build failure — this PR exists solely to test Jenkins supervisor toolingTest plan
#erroris gated behindUSE_WINDOWS_API)"Injected Windows build failure for Jenkins supervisor testing"Do not merge — this is a test PR.