Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes DoChannelOpenConf() to correctly advance the caller-provided payload index (idx) by the number of bytes consumed while decoding an SSH_MSG_CHANNEL_OPEN_CONFIRMATION, aligning its behavior with other packet decoders in src/internal.c and ensuring the receive path can reliably discard/advance past the parsed payload.
Changes:
- Update
DoChannelOpenConf()to set*idx = beginafter successfully decoding the confirmation fields. - Ensure the packet processing loop (
DoPacket()viapayloadIdx) advances correctly past the decoded payload.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JacobBarthelmeh
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes DoChannelOpenConf() so that this updates idx with the consumed length.
This issue didn't cause any real problem in current code because the buffer would be unconditionally released later.
But this shall be fixed for consistency and correctness.