Fix wolfSSH_RealPath tests#935
Merged
ejohnstown merged 1 commit intowolfSSL:masterfrom Apr 21, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR tightens the wolfSSH_RealPath unit tests so they correctly fail on mismatches, and expands coverage with additional root-preservation edge cases to exercise the prev != out branch behavior described in the PR.
Changes:
- Convert
wolfSSH_RealPath“print-only” mismatch reporting into hard assertions so failures fail the test. - Add new
RealPathtest vectors for clamping..segments at filesystem root (root-preservation behavior). - Add equivalent root-preservation cases for both default-path and NULL-default-path modes.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ejohnstown
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes wolfSSH_RealPath tests so that mismatches actually fail the test.
Also, this adds explicit cases that exercise the prev != out root-preservation branch.