Add check for all zeros in CreateMpint#939
Merged
ejohnstown merged 1 commit intowolfSSL:masterfrom Apr 21, 2026
Merged
Conversation
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #939
Scan targets checked: wolfssh-bugs, wolfssh-src
No new issues found in the changed files. ✅
ejohnstown
approved these changes
Apr 21, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a defensive guard in CreateMpint() to correctly handle the edge case where the input buffer is fully zeroed, aligning mpint encoding with RFC 4251 and avoiding invalid access.
Changes:
- Detects the “all bytes are 0x00” case after trimming leading zeros.
- Normalizes that case to an empty mpint (
sz = 0,pad = 0) and returns success.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defensive check for a fully zeroed buffer. No test infrastructure for this type of internal API.
Fixes F-2477.