Skip to content

Commit 494bf68

Browse files
committed
Run the tls13 and dtls13 earlydata pairs now that the clients process the ticket
1 parent e3610ae commit 494bf68

1 file changed

Lines changed: 15 additions & 11 deletions

File tree

.github/examples-manifest.yml

Lines changed: 15 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1166,9 +1166,13 @@ examples:
11661166
stdin: "shutdown\n"
11671167
server_exit: killed
11681168
expect: "Server: I hear ya fa shizzle"
1169-
# NOT RUN: see the note on the dtls13-earlydata pair. The server never
1170-
# sends a session ticket, so the client exits 1 on "Session ticket not
1171-
# received from server".
1169+
# the 0.5-RTT reply only prints if the 2nd connection resumed and the
1170+
# server accepted the client's 0-RTT early data
1171+
- pair:
1172+
server: [./server-tls13-earlydata]
1173+
client: [./client-tls13-earlydata, 127.0.0.1]
1174+
server_exit: killed
1175+
expect: "0.5-RTT data hello from early data server"
11721176

11731177
- pair:
11741178
server: [./server-tls13-certauth-clienthello]
@@ -1378,14 +1382,14 @@ examples:
13781382
client: [./client-dtls-callback, 127.0.0.1]
13791383
stdin: "hello\n"
13801384
server_exit: killed
1381-
# NOT RUN: the earlydata servers never send a session ticket, so the
1382-
# clients exit 1 on "Session ticket not received from server".
1383-
# Measured, not guessed: wolfSSL_read_early_data() completes the handshake
1384-
# itself, so wolfSSL_is_init_finished() is already 1 and wolfSSL_accept()
1385-
# is skipped -- and SendTls13NewSessionTicket() only runs inside accept's
1386-
# state machine (tls13.c:15984). Calling wolfSSL_send_SessionTicket()
1387-
# explicitly, and peeking >0 bytes on the client, do not help either.
1388-
# Needs someone who knows the TLS 1.3 ticket state machine.
1385+
# "Handshake complete after early data" only prints if the 2nd connection
1386+
# resumed with the ticket and the server accepted the 0-RTT early data
1387+
- pair:
1388+
server: [./server-dtls13-earlydata]
1389+
proto: udp
1390+
client: [./client-dtls13-earlydata, 127.0.0.1]
1391+
server_exit: killed
1392+
expect: "Handshake complete after early data"
13891393

13901394

13911395
- id: pkcs11

0 commit comments

Comments
 (0)