Skip to content

Commit 8cb188f

Browse files
committed
cra-kit: address Atwood review (shell safety, validation, samples)
Quote "$@" in gen-sbom --srcs (drop SC2068 disables), pass JSON paths to python via env var in validate.sh to prevent filename injection, and fail non-zero instead of warning when SBOM post-processing breaks. Rename the user_settings.h guard to CRA_KIT_USER_SETTINGS_H, clarify the serialNumber regex accepts v4 (product) and v5 (component) UUIDs, untrack the gitignored embedded sample SBOMs, document the SHA-512 CBOM omission, and note sample timestamp differences in SAMPLE-PROVENANCE.md. Signed-off-by: Sameeh Jubran <sameeh@wolfssl.com>
1 parent 04f19f8 commit 8cb188f

10 files changed

Lines changed: 44 additions & 405 deletions

File tree

cra-kit/auditor-packet/wolfssl-component-embedded/wolfssl-5.9.1.cdx.json

Lines changed: 0 additions & 328 deletions
This file was deleted.

cra-kit/auditor-packet/wolfssl-component-embedded/wolfssl-5.9.1.spdx.json

Lines changed: 0 additions & 53 deletions
This file was deleted.

cra-kit/auditor-packet/wolfssl-component/SAMPLE-PROVENANCE.md

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,3 +19,16 @@ Regenerate autotools samples and fix the product stub checksum:
1919
```sh
2020
./scripts/refresh-samples.sh
2121
```
22+
23+
## A note on timestamps
24+
25+
The sample SBOMs carry different `metadata.timestamp` / `created` values because
26+
they were generated at different times, not in a single run:
27+
28+
- `wolfssl-component/` (autotools): `2026-05-12`
29+
- `wolfssl-component-embedded/` (embedded demo): `2026-05-18`
30+
- `product-acme-connect-gateway.*` (product stub): `2026-05-18`
31+
32+
This is expected for hand-pinned samples and does not affect validation
33+
(`scripts/validate.sh` checks cross-document checksums, not timestamps).
34+
Regenerating via `refresh-samples.sh` will update them to the current time.

0 commit comments

Comments
 (0)