Fail ecc-verify when the signature does not verify

Author: aidangarske

ecc/ecc-verify.c

@@ -25,6 +25,7 @@
 #include <wolfssl/wolfcrypt/random.h>
 #include <wolfssl/wolfcrypt/ecc.h>
 #include <wolfssl/wolfcrypt/asn_public.h>
+#include <wolfssl/wolfcrypt/error-crypt.h>
 
 #if defined(WOLFSSL_CUSTOM_CURVES) && defined(HAVE_ECC_KOBLITZ)
 
@@ -83,6 +84,10 @@ int hash_firmware_verify(const byte* fwAddr, word32 fwLen, const byte* sigBuf, w
     if (ret < 0)
         goto exit;
 
+    /* a bad signature also returns 0 here: the result is in verify, not ret */
+    if (verify != 1)
+        ret = SIG_VERIFY_E;
+
 exit:
     wc_Sha256Free(&sha);
 
@@ -105,7 +110,7 @@ int main(void)
     ret = hash_firmware_verify(data, sizeof(data), sigBuf, sigLen);
     printf("hash_firmware_verify: %d\n", ret);
 
-    return 0;
+    return (ret == 0) ? 0 : 1;
 }
 
 #else