Skip to content

Commit be6753e

Browse files
committed
Key triage on the host job's real name, not a display override
1 parent 03fbe1c commit be6753e

2 files changed

Lines changed: 7 additions & 3 deletions

File tree

.github/scripts/ci_triage.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -253,6 +253,8 @@ def classify(run_id, attempt, retry_note):
253253

254254
# Jobs the nightly fans out to that emit no results-*.json. Without this they
255255
# ran every night, went red, and told nobody -- 12 of the 13 targets.
256+
# lowercased before matching: a `name:` override in nightly.yml renames every
257+
# job under it, and a case mismatch would silently make "host" a 13th target
256258
HOST_JOBS = {"host", "refs", "gate"}
257259
REF_RE = re.compile(r"wolfSSL (\S+)|\((master|v[\d.]+-stable)\)")
258260

@@ -266,13 +268,13 @@ def job_unit(name):
266268
if " / " not in name:
267269
return None, None
268270
target, rest = name.split(" / ", 1)
269-
if target in HOST_JOBS:
271+
if target.lower() in HOST_JOBS:
270272
return None, None
271273
m = REF_RE.search(rest)
272274
return target, (m.group(1) or m.group(2)) if m else "unknown"
273275

274276

275-
HOST_JOB_RE = re.compile(r"^host / (?:Run|Build) / (.+) \((.+)\)$")
277+
HOST_JOB_RE = re.compile(r"^host / (?:Run|Build) / (.+) \((.+)\)$", re.I)
276278

277279

278280
def job_urls(run_id):

.github/workflows/nightly.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,10 @@ jobs:
5151
#
5252
# The job name here is the triage unit: it prefixes every job the called
5353
# workflow produces ("esp32 / Build / ..."), and becomes the ci:<name> label.
54+
# No `name:` override -- the job name IS the triage unit, and a display name
55+
# renames every job under it ("Host / Run / dtls"), which the classifier keys
56+
# on. Keep it lowercase and identical to the other targets.
5457
host:
55-
name: Host
5658
needs: [refs]
5759
uses: ./.github/workflows/examples.yml
5860
with:

0 commit comments

Comments
 (0)