tls13: avoid to create a new suite in CertificateRequest

This way the ssl object honour the HasSigAlgo list set by
wolfSSL_set1_sigalgs_list.

Author: rizlik

src/tls13.c

@@ -7791,8 +7791,6 @@ static int SendTls13CertificateRequest(WOLFSSL* ssl, byte* reqCtx,
     int    sendSz;
     word32 i;
     word32 reqSz;
-    word16 hashSigAlgoSz = 0;
-    SignatureAlgorithms* sa;
 
     WOLFSSL_START(WC_FUNC_CERTIFICATE_REQUEST_SEND);
     WOLFSSL_ENTER("SendTls13CertificateRequest");
@@ -7802,19 +7800,12 @@ static int SendTls13CertificateRequest(WOLFSSL* ssl, byte* reqCtx,
     if (ssl->options.side != WOLFSSL_SERVER_END)
         return SIDE_ERROR;
 
-    /* Get the length of the hashSigAlgo buffer */
-    InitSuitesHashSigAlgo(NULL, SIG_ALL, 1, 1, ssl->buffers.keySz,
-        &hashSigAlgoSz);
-    sa = TLSX_SignatureAlgorithms_New(ssl, hashSigAlgoSz, ssl->heap);
-    if (sa == NULL)
-        return MEMORY_ERROR;
-    InitSuitesHashSigAlgo(sa->hashSigAlgo, SIG_ALL, 1, 1, ssl->buffers.keySz,
-        &hashSigAlgoSz);
-    ret = TLSX_Push(&ssl->extensions, TLSX_SIGNATURE_ALGORITHMS, sa, ssl->heap);
-    if (ret != 0) {
-        TLSX_SignatureAlgorithms_FreeAll(sa, ssl->heap);
-        return ret;
-    }
+    /* Remove TLSX_SingnatureAlgorithms_New from here:
+    * TLSX_SignatureAlgorithms_Write fallbacks correctly to either ssl->suites
+    * or ctx->suites to write out the Signature Algorithms extensions.
+    *
+    * The extensions is already correctly populated in DoTls13ClientHello
+    * TLSX_PopulateExtensions  */
 
     i = RECORD_HEADER_SZ + HANDSHAKE_HEADER_SZ;
 #ifdef WOLFSSL_DTLS13