Commit 2d78c98
build(sbom): Makefile.am hygiene
Five small Makefile.am improvements from the wolfssl-1zj
review pass. None changes user-facing behaviour for any
correct invocation; each closes a specific failure mode that
either silently corrupts an SBOM or leaks state.
* sbom: lib glob: $(addprefix "$(abs_builddir)/...")
quotes the prefix so an abs_builddir containing a space
no longer word-splits the test -f loop. Matches the
sbom: target's existing pattern (1zj.7).
* SOURCE_DATE_EPOCH is only exported when 'git log -1
--format=%ct' returned a non-empty string. Previously the
fallback echo on a shallow clone or corrupt repo silently
exported SOURCE_DATE_EPOCH='', which gen-sbom then treated
as 'no SDE' (warning + wallclock fallback) defeating the
reproducibility intent (1zj.9).
* --license-override and --license-text are now passed to
gen-sbom only when their corresponding Make var is set
($(if VAR,...)). The previous unconditional passthrough
relied on gen-sbom's argparse default '' to treat empty
as unset; a future gen-sbom change distinguishing those
cases would have silently mis-emitted SBOMs (1zj.10).
* install-bomsh replaces the two-tar pipeline with
cp -R src/. dst/. POSIX sh masks pipeline source-side
errors; a permission failure on 'tar cf - .' was followed
by 'tar xf -' on an empty stream succeeding, leaving a
silent partial install. cp -R is a single command whose
exit code propagates cleanly (1zj.11).
* uninstall-hook now depends on uninstall-sbom +
uninstall-bomsh instead of duplicating their bodies. Both
targets are .PHONY so the dep edge resolves; the cleanup
paths stay in lockstep with install-sbom / install-bomsh
automatically (1zj.12).
(BOMSH_OMNIBORDIR cleanup at make-clean time is handled by
the existing clean-local target in doc/include.am, which the
original PR commit extended. An earlier review attempted to
add a duplicate clean-local here; that silently overrode the
doc cleanups it relied on. The duplicate is not present in
this squashed commit.)
Closes wolfssl-1zj.6, wolfssl-1zj.7, wolfssl-1zj.9,
wolfssl-1zj.10, wolfssl-1zj.11, wolfssl-1zj.12,
wolfssl-e8o.11 parent 19ebc90 commit 2d78c98
1 file changed
Lines changed: 17 additions & 17 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
426 | 426 | | |
427 | 427 | | |
428 | 428 | | |
429 | | - | |
430 | | - | |
| 429 | + | |
| 430 | + | |
| 431 | + | |
| 432 | + | |
| 433 | + | |
431 | 434 | | |
432 | 435 | | |
433 | 436 | | |
434 | 437 | | |
435 | 438 | | |
436 | | - | |
437 | | - | |
| 439 | + | |
| 440 | + | |
438 | 441 | | |
439 | 442 | | |
440 | 443 | | |
| |||
499 | 502 | | |
500 | 503 | | |
501 | 504 | | |
502 | | - | |
503 | | - | |
504 | | - | |
| 505 | + | |
| 506 | + | |
| 507 | + | |
505 | 508 | | |
506 | 509 | | |
507 | 510 | | |
| |||
520 | 523 | | |
521 | 524 | | |
522 | 525 | | |
523 | | - | |
524 | | - | |
| 526 | + | |
525 | 527 | | |
526 | 528 | | |
527 | 529 | | |
| |||
534 | 536 | | |
535 | 537 | | |
536 | 538 | | |
537 | | - | |
538 | | - | |
539 | | - | |
540 | | - | |
541 | | - | |
542 | | - | |
543 | | - | |
544 | | - | |
| 539 | + | |
| 540 | + | |
| 541 | + | |
| 542 | + | |
| 543 | + | |
| 544 | + | |
0 commit comments