Skip to content

Commit 3300d08

Browse files
Code review feedback. Don't error out if WOLFSSL_RSA_PUBLIC_ONLY or WOLFSSL_RSA_VERIFY_ONLY are defined as they don't use blinding.
1 parent 0230659 commit 3300d08

5 files changed

Lines changed: 15 additions & 320 deletions

File tree

.wolfssl_known_macro_extras

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -651,6 +651,7 @@ WC_ASYNC_NO_SHA384
651651
WC_ASYNC_NO_SHA512
652652
WC_ASYNC_NO_X25519
653653
WC_ASYNC_THREAD_BIND
654+
WC_BLINDING_NO_RNG_ACKNOWLEDGE_WEAKNESS
654655
WC_CACHE_RESISTANT_BASE64_TABLE
655656
WC_DILITHIUM_FIXED_ARRAY
656657
WC_DISABLE_RADIX_ZERO_PAD
@@ -672,7 +673,6 @@ WC_RNG_BANK_NO_DEFAULT_SUPPORT
672673
WC_RNG_BLOCKING
673674
WC_RSA_NONBLOCK_TIME
674675
WC_RSA_NO_FERMAT_CHECK
675-
WC_RSA_NO_RNG_ACKNOWLEDGE_WEAKNESS
676676
WC_RWLOCK_OPS_INLINE
677677
WC_SKIP_INCLUDED_C_FILES
678678
WC_SLHDSA_KERNEL_ASM

doc/dox_comments/header_files/cmac.h

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -270,15 +270,21 @@ int wc_AesCmacGenerate_ex(Cmac *cmac, byte* out, word32* outSz,
270270
Cmac cmac;
271271
byte mac[WC_AES_BLOCK_SIZE];
272272
byte key[16], msg[64];
273+
int ret;
273274
274-
int ret = wc_AesCmacVerify_ex(&cmac, mac, sizeof(mac), msg,
275+
ret = wc_InitCmac_ex(&cmac, key, sizeof(key), WC_CMAC_AES, NULL,
276+
NULL, INVALID_DEVID);
277+
if (ret == 0) {
278+
ret = wc_AesCmacVerify_ex(&cmac, mac, sizeof(mac), msg,
275279
sizeof(msg), key, sizeof(key),
276280
NULL, INVALID_DEVID);
281+
}
277282
if (ret == MAC_CMP_FAILED_E) {
278283
// MAC verification failed
279284
}
280285
\endcode
281286
287+
\sa wc_InitCmac_ex
282288
\sa wc_AesCmacVerify
283289
\sa wc_AesCmacGenerate_ex
284290
*/

0 commit comments

Comments
 (0)