tests: fix static-analysis defects (clang-tidy, check-source-text)

- test_dh.c: zero-initialize priv/pub in test_wc_DhCheckKeyPair. clang-tidy
  flags pub[pubSz-1] ^= 0x01 as a read of an uninitialized variable (it
  cannot see that wc_DhGenerateKeyPair fills pub at runtime), failing
  all-c89-clang-tidy / clang-tidy-all-intelasm / clang-tidy-all-async-quic.
- test_curve25519_whitebox.c: wrap the BAD_FUNC_ARG operands in
  WC_NO_ERR_TRACE() (check-source-text unescaped-error-code check).
- test_sha3_whitebox.c: drop the bogus WOLFSSL_NO_SHA3 guard (no such
  macro; the real gate is WOLFSSL_SHA3), which check-source-text reported
  as an unknown macro.

Author: danielinux

tests/api/test_dh.c

@@ -904,7 +904,10 @@ int test_wc_DhCheckKeyPair(void)
     !defined(HAVE_SELFTEST) && !defined(HAVE_FIPS)
     DhKey key;
     WC_RNG rng;
-    byte priv[TEST_DH_BUF_SIZE], pub[TEST_DH_BUF_SIZE];
+    /* zero-initialized: wc_DhGenerateKeyPair fills pub at runtime, but the
+     * later read-modify-write (pub[pubSz-1] ^= 0x01) reads as uninitialized
+     * to clang-tidy without this. */
+    byte priv[TEST_DH_BUF_SIZE] = {0}, pub[TEST_DH_BUF_SIZE] = {0};
     word32 privSz = sizeof(priv), pubSz = sizeof(pub);
 
     ExpectIntEQ(wc_InitRng(&rng), 0);

tests/unit-mcdc/test_curve25519_whitebox.c

@@ -78,7 +78,7 @@ static void wb_make_pub_nb(void)
 
     /* key == NULL: TRUE side. */
     ret = wc_curve25519_make_pub_nb(NULL);
-    if (ret != BAD_FUNC_ARG) {
+    if (ret != WC_NO_ERR_TRACE(BAD_FUNC_ARG)) {
         WB_NOTE("wc_curve25519_make_pub_nb(NULL) did not return "
                  "BAD_FUNC_ARG");
         wb_fail = 1;
@@ -96,7 +96,7 @@ static void wb_make_pub_nb(void)
         XMEMSET(&key, 0, sizeof(key));
         key.nb_ctx = NULL;
         ret = wc_curve25519_make_pub_nb(&key);
-        if (ret != BAD_FUNC_ARG) {
+        if (ret != WC_NO_ERR_TRACE(BAD_FUNC_ARG)) {
             WB_NOTE("wc_curve25519_make_pub_nb(nb_ctx==NULL) did not "
                      "return BAD_FUNC_ARG");
             wb_fail = 1;
@@ -157,7 +157,7 @@ static void wb_make_key_nb(void)
     /* key == NULL: TRUE side (rng operand short-circuited, not evaluated
      * -- unique-cause MC/DC only requires this operand's own pair). */
     ret = wc_curve25519_make_key_nb(&rng, CURVE25519_KEYSIZE, NULL);
-    if (ret != BAD_FUNC_ARG) {
+    if (ret != WC_NO_ERR_TRACE(BAD_FUNC_ARG)) {
         WB_NOTE("wc_curve25519_make_key_nb(NULL key) did not return "
                  "BAD_FUNC_ARG");
         wb_fail = 1;
@@ -166,7 +166,7 @@ static void wb_make_key_nb(void)
     /* rng == NULL, key != NULL: second operand's TRUE side with the first
      * operand false. */
     ret = wc_curve25519_make_key_nb(NULL, CURVE25519_KEYSIZE, &key);
-    if (ret != BAD_FUNC_ARG) {
+    if (ret != WC_NO_ERR_TRACE(BAD_FUNC_ARG)) {
         WB_NOTE("wc_curve25519_make_key_nb(NULL rng) did not return "
                  "BAD_FUNC_ARG");
         wb_fail = 1;
@@ -176,7 +176,7 @@ static void wb_make_key_nb(void)
      * following "if (ret==0 && ...)" compound (first operand FALSE side). */
     key.nb_ctx = NULL;
     ret = wc_curve25519_make_key_nb(&rng, CURVE25519_KEYSIZE, &key);
-    if (ret != BAD_FUNC_ARG) {
+    if (ret != WC_NO_ERR_TRACE(BAD_FUNC_ARG)) {
         WB_NOTE("wc_curve25519_make_key_nb(nb_ctx==NULL) did not return "
                  "BAD_FUNC_ARG");
         wb_fail = 1;

tests/unit-mcdc/test_sha3_whitebox.c

@@ -60,7 +60,7 @@
 static int wb_fail = 0;
 #define WB_NOTE(msg) do { printf("  [wb] %s\n", (msg)); } while (0)
 
-#if !defined(WOLFSSL_NO_SHA3) && defined(WOLFSSL_SHA3) && \
+#if defined(WOLFSSL_SHA3) && \
     defined(USE_INTEL_SPEEDUP) && !defined(WC_C_DYNAMIC_FALLBACK)
 
 /* Run InitSha3 once with cpuid_flags/sha3_block forced, without hashing. The
@@ -177,7 +177,7 @@ static void wb_sha3_dispatch(void)
  * real (non-INITIALIZER) value and vary sha3_block, without hashing, so no
  * asm block ever executes.
  */
-#if !defined(WOLFSSL_NO_SHA3) && defined(WOLFSSL_SHA3) && \
+#if defined(WOLFSSL_SHA3) && \
     defined(__aarch64__) && defined(WOLFSSL_ARMASM) && \
     !defined(WC_C_DYNAMIC_FALLBACK)
 
@@ -225,7 +225,7 @@ static void wb_sha3_dispatch_aarch64(void)
 int main(void)
 {
     printf("sha3.c white-box MC/DC supplement\n");
-#if defined(WOLFSSL_NO_SHA3) || !defined(WOLFSSL_SHA3)
+#if !defined(WOLFSSL_SHA3)
     printf("  SHA-3 not enabled; nothing to exercise\n");
     return 0;
 #else