Address warning in wolfDTLS_SetChGoodCb

embhorn · embhorn · commit 40de65785cd6 · 2026-05-19T13:05:12.000-05:00
diff --git a/src/ssl.c b/src/ssl.c
@@ -7536,6 +7536,11 @@ int wolfDTLS_accept_stateless(WOLFSSL* ssl)
     return ret;
 }
 
+/* WC_NO_INLINE: wolfDTLS_accept_stateless passes the address of a stack-local
+ * context here; the restore call before return clears it again. Preventing
+ * inlining hides that cross-frame assignment from GCC's -Wdangling-pointer
+ * analysis, which otherwise flags a false positive on GCC 14+. */
+WC_NO_INLINE
 int wolfDTLS_SetChGoodCb(WOLFSSL* ssl, ClientHelloGoodCb cb, void* user_ctx)
 {
     WOLFSSL_ENTER("wolfDTLS_SetChGoodCb");

Original file line number	Diff line number	Diff line change
`@@ -7536,6 +7536,11 @@ int wolfDTLS_accept_stateless(WOLFSSL* ssl)`
`7536`	`7536`	`return ret;`
`7537`	`7537`	`}`
`7538`	`7538`
	`7539`	`+/* WC_NO_INLINE: wolfDTLS_accept_stateless passes the address of a stack-local`
	`7540`	`+ * context here; the restore call before return clears it again. Preventing`
	`7541`	`+ * inlining hides that cross-frame assignment from GCC's -Wdangling-pointer`
	`7542`	`+ * analysis, which otherwise flags a false positive on GCC 14+. */`
	`7543`	`+WC_NO_INLINE`
`7539`	`7544`	`int wolfDTLS_SetChGoodCb(WOLFSSL* ssl, ClientHelloGoodCb cb, void* user_ctx)`
`7540`	`7545`	`{`
`7541`	`7546`	`WOLFSSL_ENTER("wolfDTLS_SetChGoodCb");`