wolfcrypt/src/wc_xmss_impl.c: in wc_xmss_bds_state_treehash_complete(), add suppression for false positive clang-analyzer-core.NullDereference from LLVM-21 pre20250523+.

douzzer · douzzer · commit af78ed8b6f8b · 2025-06-20T15:31:31.000-05:00
diff --git a/wolfcrypt/src/wc_xmss_impl.c b/wolfcrypt/src/wc_xmss_impl.c
@@ -2590,7 +2590,7 @@ static void wc_xmss_bds_state_treehash_set_next_idx(BdsState* bds, int i,
 static void wc_xmss_bds_state_treehash_complete(BdsState* bds, int i)
 {
     byte* sk = bds->treeHash + i * 4;
-    sk[3] |= 1 << 7;
+    sk[3] |= 1 << 7; /* // NOLINT(clang-analyzer-core.NullDereference) */
 }
 
 /* Get the tree hash data at specified index for the BDS state.

Original file line number	Diff line number	Diff line change
`@@ -2590,7 +2590,7 @@ static void wc_xmss_bds_state_treehash_set_next_idx(BdsState* bds, int i,`
`2590`	`2590`	`static void wc_xmss_bds_state_treehash_complete(BdsState* bds, int i)`
`2591`	`2591`	`{`
`2592`	`2592`	`byte* sk = bds->treeHash + i * 4;`
`2593`		`- sk[3] \|= 1 << 7;`
	`2593`	`+ sk[3] \|= 1 << 7; /* // NOLINT(clang-analyzer-core.NullDereference) */`
`2594`	`2594`	`}`
`2595`	`2595`
`2596`	`2596`	`/* Get the tree hash data at specified index for the BDS state.`