Code review feedback

kareem-wolfssl · kareem-wolfssl · commit f8d59055972d · 2026-07-10T16:35:33.000-07:00
diff --git a/wolfcrypt/src/pkcs7.c b/wolfcrypt/src/pkcs7.c
@@ -7645,7 +7645,9 @@ static int PKCS7_VerifySignedData(wc_PKCS7* pkcs7, const byte* hashBuf,
                                     (int)(localIdx - certIdx), length)) {
                             ret = ASN_PARSE_E;
                         }
-                        idx = certIdx;
+                        else {
+                            idx = certIdx;
+                        }
                     }
                 }
                 /* in case certificates set has definite length  */

Original file line number	Diff line number	Diff line change
`@@ -7645,7 +7645,9 @@ static int PKCS7_VerifySignedData(wc_PKCS7* pkcs7, const byte* hashBuf,`
`7645`	`7645`	`(int)(localIdx - certIdx), length)) {`
`7646`	`7646`	`ret = ASN_PARSE_E;`
`7647`	`7647`	`}`
`7648`		`- idx = certIdx;`
	`7648`	`+ else {`
	`7649`	`+ idx = certIdx;`
	`7650`	`+ }`
`7649`	`7651`	`}`
`7650`	`7652`	`}`
`7651`	`7653`	`/* in case certificates set has definite length */`