Skip to content

Additional fixes#10116

Merged
douzzer merged 5 commits intowolfSSL:masterfrom
Frauschi:zd21457
Apr 7, 2026
Merged

Additional fixes#10116
douzzer merged 5 commits intowolfSSL:masterfrom
Frauschi:zd21457

Conversation

@Frauschi
Copy link
Copy Markdown
Contributor

@Frauschi Frauschi commented Apr 1, 2026

zd21457

@Frauschi Frauschi added the For This Release Release version 5.9.1 label Apr 1, 2026
Copy link
Copy Markdown

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #10116

Scan targets checked: src, src-bugs, src-compliance, wolfcrypt-api_misuse, wolfcrypt-bugs, wolfcrypt-compliance, wolfcrypt-concurrency, wolfcrypt-portability, wolfcrypt-src

No new issues found in the changed files. ✅

@Frauschi Frauschi force-pushed the zd21457 branch 2 times, most recently from 77407d5 to 559d88e Compare April 2, 2026 11:34
@douzzer
Copy link
Copy Markdown
Contributor

douzzer commented Apr 2, 2026

only failing subtest is multi-test all-c89-clang-tidy "FAIL: scripts/ocsp-stapling2.test"

@douzzer douzzer added Staged Staged for merge pending final test results and review and removed Staged Staged for merge pending final test results and review labels Apr 2, 2026
Copy link
Copy Markdown
Contributor

@douzzer douzzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing some FIPS gating I suspect, re "Properly reject Ed448 identity public key"

[linuxkm-defaults-all-fips-v6-sanitizer] [35 of 52] [5a573e0c76]
    setting up FIPS "v6-linuxkm"... 
    refreshing fips WCv6.0.0-linuxkm-UPDT-RC3... [caching link to git@github.com... done]  done, now at 7756dbea90
    setting up FIPS "v6-linuxkm"...     refreshing wolfssl WCv6.0.0-linuxkm-UPDT-RC2... done, now at b7220aeb4b
done [fips="WCv6.0.0-linuxkm-UPDT-RC3" (7756dbea90), wolfCrypt="WCv6.0.0-linuxkm-UPDT-RC2" (def685129c)]
    configure with sanitizers...   real 0m10.090s  user 0m6.531s  sys 0m4.403s
    build...   real 0m38.522s  user 8m9.887s  sys 0m9.403s
    fixing FIPS hash in user library... done.
    check...FAIL: scripts/unit.test
   real 1m23.506s  user 2m1.463s  sys 0m15.917s
ERROR - tests/api.c line 6719 failed with:
    expected: wolfSSL_shutdown(ssl_c) == WOLFSSL_SUCCESS
    result:   2 != 1
ERROR - tests/api.c line 34781 failed with:
    expected: wc_ed448_import_public_fips(identity, sizeof(identity), &key) != 0
    result:   0 == 0
ERROR - tests/api.c line 36066 failed with:
    expected: Test failed
    result:   ret 0
   1306: test_pkcs7_decode_encrypted_outputsz               : skipped
   1307: test_pkcs7_ori_oversized_oid                       : skipped
   1308: test_wolfSSL_Cleanup                               : passed (  0.00001)

FAILURES:
   1305: test_ed448_rejects_identity_key

 End API Tests
 Failed/Skipped/Passed/All: 1/443/864/1308
FAIL scripts/unit.test (exit status: 1)

scripts/unit.log tail:
   1306: test_pkcs7_decode_encrypted_outputsz               : skipped
   1307: test_pkcs7_ori_oversized_oid                       : skipped
   1308: test_wolfSSL_Cleanup                               : passed (  0.00001)

FAILURES:
   1305: test_ed448_rejects_identity_key

 End API Tests
 Failed/Skipped/Passed/All: 1/443/864/1308
FAIL scripts/unit.test (exit status: 1)
    linuxkm-defaults-all-fips-v6-sanitizer fail_analytic_check
    failed config: 'EXTRA_CPPFLAGS=-Werror' '--srcdir' '.' '--disable-jobserver' '--enable-option-checking=fatal' '--enable-fips=v6' '--enable-linuxkm-defaults' '--enable-intelasm' '--enable-sp-asm' '--enable-all' '--enable-acert' '--enable-dtls13' '--enable-dtls-mtu' '--enable-dtls-frag-ch' '--enable-dtlscid' '--enable-quic' '--with-sys-crypto-policy' '--disable-srtp' 'CC=gcc-16' 'LDFLAGS=-g -fno-omit-frame-pointer -fsanitize-recover=all -fsanitize=address,pointer-subtract,leak,undefined,float-cast-overflow,float-divide-by-zero,bounds-strict -fsanitize-recover=all ' 'CFLAGS=-DTEST_ALWAYS_RUN_TO_END -Wno-declaration-after-statement -DDEBUG_LINUXKM_PIE_SUPPORT -DWC_SIPHASH_NO_ASM -DWC_DEBUG_CIPHER_LIFECYCLE -g -fno-omit-frame-pointer -fsanitize=address,pointer-subtract,leak,undefined,float-cast-overflow,float-divide-by-zero,bounds-strict -fsanitize-recover=all --param=max-vartrack-size=128000000' 'CPPFLAGS=-DNO_WOLFSSL_CIPHER_SUITE_TEST -pedantic -Wnull-dereference -Wdeclaration-after-statement'

Frauschi added 5 commits April 5, 2026 11:32
Reported by: Nicholas Carlini <npc@anthropic.com>
Reported by: Nicholas Carlini <npc@anthropic.com>
Reported by: Nicholas Carlini <npc@anthropic.com>
Reported by: Nicholas Carlini <npc@anthropic.com>
Reported by: Nicholas Carlini <npc@anthropic.com>
@Frauschi
Copy link
Copy Markdown
Contributor Author

Frauschi commented Apr 5, 2026

@douzzer I fixed the FIPS gating

@Frauschi Frauschi requested a review from douzzer April 5, 2026 11:34
@douzzer douzzer added the Staged Staged for merge pending final test results and review label Apr 7, 2026
@douzzer douzzer merged commit efe6ad4 into wolfSSL:master Apr 7, 2026
494 of 497 checks passed
@Frauschi Frauschi deleted the zd21457 branch April 7, 2026 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

For This Release Release version 5.9.1 Staged Staged for merge pending final test results and review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants