Implementation for PEM_write_PrivateKey & PEM_write_PUBKEY#10317
Open
Roy-Carter wants to merge 5 commits intowolfSSL:masterfrom
Open
Implementation for PEM_write_PrivateKey & PEM_write_PUBKEY#10317Roy-Carter wants to merge 5 commits intowolfSSL:masterfrom
Roy-Carter wants to merge 5 commits intowolfSSL:masterfrom
Conversation
Contributor
Author
|
@julek-wolfssl could you run the workflow on this ? |
|
Can one of the admins verify this patch? |
Member
|
Okay to test. Contributor agreement on file. |
|
Roy-Carter
force-pushed
the
feature/pem_write_enhancement
branch
from
a5506d0 to
4f700a4
Compare
Contributor
Author
|
same here , vpn test failed , rebased to master @julek-wolfssl |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As part of a continuous integration from OpenSSL I came across the missing functions of : PEM_write_PrivateKey & PEM_write_PUBKEY while their read does exist , i've reversed the logic based on the read implementation to also support compatibility for write .
Testing
Tested via adding 2 new tests
Checklist