tls.c: send missing_extension alert on TLS 1.3 SNI absence#10332
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR adjusts TLS alert behavior in TLSX_SNI_VerifyParse to better align with TLS 1.3 expectations by sending a different fatal alert when SNI is missing or doesn’t match.
Changes:
- For TLS 1.3+, send
missing_extensioninstead ofhandshake_failurewhen SNI is absent. - For TLS 1.3+, also send
missing_extensioninstead ofhandshake_failurewhen SNI hasNO_MATCH. - Preserve
handshake_failurebehavior for pre–TLS 1.3.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #10332
Scan targets checked: wolfssl-bugs, wolfssl-src
No new issues found in the changed files. ✅
Contributor
|
Jenkins retest this please. |
Member
|
Jenkins retest this please. PRB-fsanitize-addr-v3 -> FAIL: scripts/resume.test |
dgarske
reviewed
May 20, 2026
SparkiDev
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the alert handling logic in the
TLSX_SNI_VerifyParsefunction to improve compliance with TLS 1.3 requirements. Specifically, it changes the type of alert sent when the SNI (Server Name Indication) extension is absent or does not match, sending amissing_extensionalert for TLS 1.3 and above, while maintaining the previous behavior for earlier versions.Alert handling improvements for TLS 1.3:
TLSX_SNI_VerifyParseinsrc/tls.cto send amissing_extensionalert instead ofhandshake_failurewhen the SNI extension is missing or has no match, but only for TLS 1.3 and above. For earlier versions, the function still sendshandshake_failure. [1] [2]