Skip to content

tls.c: send missing_extension alert on TLS 1.3 SNI absence #10332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SparkiDev merged 1 commit into from
May 26, 2026
Merged

tls.c: send missing_extension alert on TLS 1.3 SNI absence #10332

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/tls.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2593,7 +2593,10 @@ static int TLSX_SNI_VerifyParse(WOLFSSL* ssl, byte isRequest)
continue;
}

SendAlert(ssl, alert_fatal, handshake_failure);
SendAlert(ssl, alert_fatal,
IsAtLeastTLSv1_3(ssl->version)
? missing_extension
Comment thread
SparkiDev marked this conversation as resolved.
: handshake_failure);
Comment thread
jackctj117 marked this conversation as resolved.
WOLFSSL_ERROR_VERBOSE(SNI_ABSENT_ERROR);
return SNI_ABSENT_ERROR;
}
Expand All @@ -2604,7 +2607,10 @@ static int TLSX_SNI_VerifyParse(WOLFSSL* ssl, byte isRequest)
if (ssl_sni->status != WOLFSSL_SNI_NO_MATCH)
continue;

SendAlert(ssl, alert_fatal, handshake_failure);
SendAlert(ssl, alert_fatal,
IsAtLeastTLSv1_3(ssl->version)
? missing_extension
: handshake_failure);
Comment thread
jackctj117 marked this conversation as resolved.
Comment thread
jackctj117 marked this conversation as resolved.
WOLFSSL_ERROR_VERBOSE(SNI_ABSENT_ERROR);
return SNI_ABSENT_ERROR;
}
Expand Down
Loading