harden falcon key handling#10340
Open
JeremiahM37 wants to merge 2 commits intowolfSSL:masterfrom
Open
Conversation
|
Contributor
|
Please note that the liboqs-based SPHINCS implementation is about to be dropped completely in #10261, so no changes for this are required. |
JeremiahM37
changed the title
Contributor
Author
|
Jenkins retest this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
F-3316, F-3317, F-3320,F-3321.wc_sphincs_check_key: actually validate level/optim/keySet flags and compare embedded PK against key->p (was always returning 0)GetKeyOID sphincs: replace dead else-if chain so all six variants are detected (was only ever trying fast-L1)