zero-initialize DecodedCert immediately after allocation in wolfSSL_CertManagerCABufferType#10437
Open
gasbytes wants to merge 1 commit intowolfSSL:masterfrom
Open
Conversation
|
Contributor
Author
|
Jenkins retest this please |
Contributor
Author
|
Jenkins retest this please (lost logs) |
wolfssl_certmanagerloadcabuffertype to prevent cleanup on an uninitialized struct on the pem error path.
gasbytes
force-pushed
the
CertManagerLoadCABufferType_MoveXMemset
branch
from
5c4922c to
66bc5ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
zero-initialize DecodedCert immediately after allocation in wolfSSL_CertManagerCABufferType to prevent cleanup on an uninitialized struct on the pem error path.
Fixes zd#21777
Testing
Against reproducer from zd#21777 with:
./configure --enable-debug --enable-pkcs7=no --enable-opensslall=no --enable-opensslextra=no --enable-shared --enable-static
as configuration.
Checklist