NULL the correct key in TLSX_KeyShare_ProcessPqcHybridClient when using WOLFSSL_TLSX_PQC_MLKEM_STORE_OBJ.#10493
Merged
Merged
Conversation
…ng WOLFSSL_TLSX_PQC_MLKEM_STORE_OBJ. Thanks to Haiyang Huang for the report.
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes an async-cleanup bug in the TLS 1.3 PQC-hybrid (ECC + ML-KEM) client key-share processing when WOLFSSL_TLSX_PQC_MLKEM_STORE_OBJ is enabled, ensuring the correct ML-KEM private-key pointer is nulled to avoid being freed while the operation is pending.
Changes:
- In the
WC_PENDING_Epath, conditionally nullspqc_kse->key(object-storage mode) instead ofpqc_kse->privKey(byte-storage mode). - Preserves existing behavior for non-
WOLFSSL_TLSX_PQC_MLKEM_STORE_OBJbuilds.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Frauschi
approved these changes
May 18, 2026
|
dgarske
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes zd#21852
Testing
Provided reproducer + built in tests
Checklist