Add UDP support to NetX sockets for DTLS sessions#10501
Open
hmohide wants to merge 2 commits into
Open
Conversation
Author
|
@dgarske i have rebased. Please check |
|
Can one of the admins verify this patch? |
Member
|
Okay to test. Thank you @hmohide . Contributor agreement on file. |
Author
|
@dgarske do i need do something for this PR? |
Member
|
Jenkins retest this please. History lost |
Member
Member
|
Jenkins retest this please. History lost |
dgarske
requested changes
Jun 9, 2026
| typedef struct NetX_Ctx { | ||
| NX_TCP_SOCKET* nxSocket; /* send/recv socket handle */ | ||
| NX_TCP_SOCKET* nxTcpSocket; /* send/recv tcp socket handle */ | ||
| NX_UDP_SOCKET* nxUdpSocket; /* send/recv udp socket handle */ |
Member
There was a problem hiding this comment.
Perhaps only include this in the struct when WOLFSSL_DTLS is defined? Same with the other two at bottom?
|
|
||
| if(nxCtx->nxdIp->nxd_ip_version == NX_IP_VERSION_V4) | ||
| { | ||
| status = nx_udp_socket_send(nxCtx->nxUdpSocket, packet, nxCtx->nxdIp->nxd_ip_address.v4, (UINT)(*nxCtx->nxPort)); |
Member
There was a problem hiding this comment.
overlong lines added:
src/wolfio.c:2721 status = nx_udp_socket_send(nxCtx->nxUdpSocket, packet, nxCtx->nxdIp->nxd_ip_address.v4, (UINT)(*nxCtx->nxPort));
src/wolfio.c:2729 status = nxd_udp_socket_send(nxCtx->nxUdpSocket, packet, nxCtx->nxdIp, (UINT)(*nxCtx->nxPort));
src/wolfio.c:2749 void wolfSSL_SetIO_NetX_Dtls(WOLFSSL* ssl, NX_UDP_SOCKET* nxsocket, NXD_ADDRESS *nxdip, USHORT *nxport, ULONG waitoption)
wolfssl/wolfio.h:793 WOLFSSL_LOCAL int NetX_ReceiveFrom(WOLFSSL *ssl, char *buf, int sz, void *ctx);
wolfssl/wolfio.h:798 WOLFSSL_API void wolfSSL_SetIO_NetX_Dtls(WOLFSSL* ssl, NX_UDP_SOCKET* nxsocket,
check-source-text fail_A
Member
|
@hmohide looks like that last push didn't get those fixes? Could just be Github but I don't see them |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add UDP support to NetX sockets for DTLS sessions
Fixes zd#
src/internal.c
src/wolfio.c
wolfssl/internal.h
wolfssl/wolfio.h
Testing
Yes, verified the DTLS communication with multiple session
Checklist